Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752486AbcL2HU7 (ORCPT ); Thu, 29 Dec 2016 02:20:59 -0500 Received: from smtp02.smtpout.orange.fr ([80.12.242.124]:49672 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751167AbcL2HU5 (ORCPT ); Thu, 29 Dec 2016 02:20:57 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Thu, 29 Dec 2016 08:20:55 +0100 X-ME-IP: 92.136.203.19 From: Robert Jarzmik To: Linus Walleij Cc: Arvind Yadav , Daniel Mack , Haojian Zhuang , "linux-arm-kernel\@lists.infradead.org" , "linux-gpio\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" Subject: Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions References: <1481207730-6332-1-git-send-email-arvind.yadav.cs@gmail.com> X-URL: http://belgarath.falguerolles.org/ Date: Thu, 29 Dec 2016 08:20:49 +0100 In-Reply-To: (Linus Walleij's message of "Tue, 27 Dec 2016 13:49:06 +0100") Message-ID: <87o9zvw69a.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 735 Lines: 23 Linus Walleij writes: > On Thu, Dec 8, 2016 at 3:35 PM, Arvind Yadav wrote: > >> In functions pxa2xx_build_functions, the memory allocated for >> 'functions' is live within the function only. After the >> allocation it is immediately freed with devm_kfree. There is >> no need to allocate memory for 'functions' with devm function >> so replace devm_kcalloc with kcalloc and devm_kfree with kfree. >> >> Signed-off-by: Arvind Yadav > > I want the maintainer Robert Jarzmik to review this before I do anything Hi Linus, I did review, on December the 10th. I wasn't very enthusiastic about the patch, if you check back my reply. Cheers. -- Robert