Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752624AbcL2ICz (ORCPT ); Thu, 29 Dec 2016 03:02:55 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:43411 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752394AbcL2ICx (ORCPT ); Thu, 29 Dec 2016 03:02:53 -0500 Date: Thu, 29 Dec 2016 00:02:50 -0800 From: Christoph Hellwig To: Jason Baron Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Sathya Prakash , Chaitra P B , Suganath Prabu Subramani , Sreekanth Reddy , Hannes Reinecke , "Martin K. Petersen" , Bart Van Assche , Sagi Grimberg , James Bottomley , Christoph Hellwig , Doug Ledford , David Miller Subject: Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands Message-ID: <20161229080250.GA11605@infradead.org> References: <1482985824-7270-1-git-send-email-jbaron@akamai.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1482985824-7270-1-git-send-email-jbaron@akamai.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 655 Lines: 15 On Wed, Dec 28, 2016 at 11:30:24PM -0500, Jason Baron wrote: > Add a new parameter to scsi_internal_device_block() to decide whether > or not to invoke scsi_wait_for_queuecommand(). We'll also need to deal with the blk-mq wait path that Bart has been working on (I think it's already in the scsi tree, but I'd have to check). Also adding a bool flag for the last call in a function is style that's a little annoying. I'd prefer to add a scsi_internal_device_block_nowait that contains all the code except for the waiting, and then make scsi_internal_device_block_nowait a wrapper around it. Or drop the annoying internal for both while we're at it :)