Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752541AbcL2Isj (ORCPT ); Thu, 29 Dec 2016 03:48:39 -0500 Received: from b.ns.miles-group.at ([95.130.255.144]:44725 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752399AbcL2Ish (ORCPT ); Thu, 29 Dec 2016 03:48:37 -0500 Subject: Re: [PATCH 6/6] ubifs: Wire up NFS support To: "J. Bruce Fields" References: <1480629741-18375-1-git-send-email-richard@nod.at> <1480629741-18375-7-git-send-email-richard@nod.at> <20161229025650.GB21325@fieldses.org> Cc: linux-mtd@lists.infradead.org, david@sigma-star.at, tytso@mit.edu, dedekind1@gmail.com, adrian.hunter@intel.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, adilger.kernel@dilger.ca, akpm@linux-foundation.org, linux-ext4@vger.kernel.org From: Richard Weinberger Message-ID: Date: Thu, 29 Dec 2016 09:48:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <20161229025650.GB21325@fieldses.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 410 Lines: 20 Bruce, On 29.12.2016 03:56, J. Bruce Fields wrote: >> - * Note, d_splice_alias() would be required instead if we supported >> - * NFS. >> - */ >> - d_add(dentry, inode); >> + >> + d_splice_alias(inode, dentry); >> return NULL; > > I'm pretty sure that should be > > return d_splice_alias(inode, dentry); You are right. /me assumed d_splice_alias() is consistent with d_add(). :-( Thanks, //richard