Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752640AbcL2JNG (ORCPT <rfc822;w@1wt.eu>);
        Thu, 29 Dec 2016 04:13:06 -0500
Received: from mx2.suse.de ([195.135.220.15]:54032 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752436AbcL2JNE (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 29 Dec 2016 04:13:04 -0500
Date: Thu, 29 Dec 2016 10:12:57 +0100
From: Michal Hocko <mhocko@kernel.org>
To: Eric Anholt <eric@anholt.net>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        linux-stable <stable@vger.kernel.org>,
        "Robin H. Johnson" <robbat2@orbis-terrarum.net>,
        Michal Nazarewicz <mina86@mina86.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] mm: Drop "PFNs busy" printk in an expected path.
Message-ID: <20161229091256.GF29208@dhcp22.suse.cz>
References: <20161229023131.506-1-eric@anholt.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161229023131.506-1-eric@anholt.net>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1875
Lines: 52

This has been already brought up
http://lkml.kernel.org/r/20161130092239.GD18437@dhcp22.suse.cz and there
was a proposed patch for that which ratelimited the output
http://lkml.kernel.org/r/20161130132848.GG18432@dhcp22.suse.cz resp.
http://lkml.kernel.org/r/robbat2-20161130T195244-998539995Z@orbis-terrarum.net

then the email thread just died out because the issue turned out to be a
configuration issue. Michal indicated that the message might be useful
so dropping it completely seems like a bad idea. I do agree that
something has to be done about that though. Can we reconsider the
ratelimit thing?

On Wed 28-12-16 18:31:31, Eric Anholt wrote:
> For CMA allocations, we expect to occasionally hit this error path, at
> which point CMA will retry.  Given that, we shouldn't be spamming
> dmesg about it.
> 
> The Raspberry Pi graphics driver does frequent CMA allocations, and
> during regression testing this printk was sometimes occurring 100s of
> times per second.
> 
> Signed-off-by: Eric Anholt <eric@anholt.net>
> Cc: linux-stable <stable@vger.kernel.org>
> ---
>  mm/page_alloc.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 6de9440e3ae2..bea7204c14a5 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -7289,8 +7289,6 @@ int alloc_contig_range(unsigned long start, unsigned long end,
>  
>  	/* Make sure the range is really isolated. */
>  	if (test_pages_isolated(outer_start, end, false)) {
> -		pr_info("%s: [%lx, %lx) PFNs busy\n",
> -			__func__, outer_start, end);
>  		ret = -EBUSY;
>  		goto done;
>  	}
> -- 
> 2.11.0
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

-- 
Michal Hocko
SUSE Labs