Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752726AbcL2JaT (ORCPT ); Thu, 29 Dec 2016 04:30:19 -0500 Received: from mail.skyhub.de ([78.46.96.112]:48401 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752701AbcL2JaS (ORCPT ); Thu, 29 Dec 2016 04:30:18 -0500 Date: Thu, 29 Dec 2016 10:30:12 +0100 From: Borislav Petkov To: Andy Lutomirski Cc: Junichi Nomura , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" Subject: Re: [PATCH 1/2] x86/CPU: Add native CPUID variants returning a single datum Message-ID: <20161229093012.GA11221@nazgul.tnic> References: <2f771739-a617-0870-2f68-2a8ebba0bc46@ce.jp.nec.com> <20161228111830.GA21788@nazgul.tnic> <20161228112023.GB21788@nazgul.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 559 Lines: 16 On Wed, Dec 28, 2016 at 10:11:22AM -0800, Andy Lutomirski wrote: > On a very quick read, it looks like none of your new call sites > actually use the return value at all. Since you also appear to be > consolidating them all, would it make sense to just open-code the > single (?) remaining user? I've got stuff coming up which will use the retval but it is not fully cooked yet. And also, we want to have generic helpers so that people do not reimplement them left and right. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --