Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752761AbcL2JgU (ORCPT <rfc822;w@1wt.eu>);
        Thu, 29 Dec 2016 04:36:20 -0500
Received: from mail.skyhub.de ([78.46.96.112]:38593 "EHLO mail.skyhub.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752698AbcL2JgT (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 29 Dec 2016 04:36:19 -0500
Date: Thu, 29 Dec 2016 10:36:14 +0100
From: Borislav Petkov <bp@alien8.de>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Junichi Nomura <j-nomura@ce.jp.nec.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>, "hpa@zytor.com" <hpa@zytor.com>
Subject: Re: [PATCH 3/2] x86/microcode/intel: Add a helper which gives the
 microcode revision
Message-ID: <20161229093614.GB11221@nazgul.tnic>
References: <2f771739-a617-0870-2f68-2a8ebba0bc46@ce.jp.nec.com>
 <20161228111830.GA21788@nazgul.tnic>
 <20161228112120.GC21788@nazgul.tnic>
 <20161228125354.GA30537@nazgul.tnic>
 <CALCETrVnUbiZZabLZkhQHadzJ_cdbdVoUW3RTcNnZz8CGnsjNg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CALCETrVnUbiZZabLZkhQHadzJ_cdbdVoUW3RTcNnZz8CGnsjNg@mail.gmail.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 606
Lines: 19

On Wed, Dec 28, 2016 at 10:12:22AM -0800, Andy Lutomirski wrote:
> As in the other email, could this just be native_cpuid()?

Right, so we only have use for the native_cpuid_eax() variant right now
but having them all is nicely consistent. They come for almost for free
too.

Also, they're cpuid_<reg>() counterparts and if we don't add the
native_cpuid_e[bcd]x() now I can already see the question: "But but, why
didn't you implement the rest of the CPUID regs?"

Considering how cheap they are, I'd say we keep them all 4.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--