Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752821AbcL2Jo5 (ORCPT ); Thu, 29 Dec 2016 04:44:57 -0500 Received: from mail-yw0-f179.google.com ([209.85.161.179]:34806 "EHLO mail-yw0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752442AbcL2Joy (ORCPT ); Thu, 29 Dec 2016 04:44:54 -0500 MIME-Version: 1.0 In-Reply-To: References: <20161124233824.17424-1-gary.bisson@boundarydevices.com> <20161202163520.22927-1-gary.bisson@boundarydevices.com> <20161202163520.22927-3-gary.bisson@boundarydevices.com> From: Gary Bisson Date: Thu, 29 Dec 2016 10:44:53 +0100 Message-ID: Subject: Re: [RFC v2 2/3] pinctrl: imx: use radix trees for groups and functions To: Linus Walleij Cc: Fabio Estevam , Shawn Guo , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Pantelis Antoniou , Vladimir Zapolskiy Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1204 Lines: 33 Hi Linus, All, On Tue, Dec 27, 2016 at 11:07 PM, Linus Walleij wrote: > > On Fri, Dec 2, 2016 at 5:35 PM, Gary Bisson > wrote: > > > This change is inspired from the pinctrl-single architecture. > > > > The problem with current implementation is that it isn't possible > > to add/remove functions and/or groups dynamically. The radix tree > > offers an easy way to do so. The intent is to offer a follow-up > > patch later that will enable the use of pinctrl nodes in dt-overlays. > > > > Signed-off-by: Gary Bisson > > This patch doesn't apply on v4.10-rc1 so please rebase it > on the mainline and resend as v3, include Fabio's review tag. Actually it applies if the first patch of this v2 series is also applied first. https://patchwork.kernel.org/patch/9458883/ https://patchwork.kernel.org/patch/9458889/ The 3rd patch of the series can be discarded though since it was just an example to show the benefit of the first two. I guess someone needs to also ack/review the first one. Because switching to radix tree keeping the const qualifier of the driver structure isn't really useful. Regards, Gary