Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752787AbcL2Oqc (ORCPT ); Thu, 29 Dec 2016 09:46:32 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:41474 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752311AbcL2Oqa (ORCPT ); Thu, 29 Dec 2016 09:46:30 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 33B036126E Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH v5 09/14] ACPI: platform: setup MSI domain for ACPI based platform device To: Hanjun Guo , "Rafael J. Wysocki" References: <1482384922-21507-1-git-send-email-guohanjun@huawei.com> <1482384922-21507-10-git-send-email-guohanjun@huawei.com> <585E24FB.9050805@huawei.com> <586072E9.3060609@huawei.com> Cc: Marc Zyngier , "Rafael J. Wysocki" , Lorenzo Pieralisi , ACPI Devel Maling List , "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List , Thomas Gleixner , Greg KH , Tomasz Nowicki , Ma Jun , Kefeng Wang , Agustin Vega-Frias , Charles Garcia-Tobin , huxinwei@huawei.com, yimin@huawei.com, linuxarm@huawei.com, Jon Masters , Hanjun Guo From: Sinan Kaya Message-ID: <9aa650ad-a32d-e942-1c6b-b069c8a2b87a@codeaurora.org> Date: Thu, 29 Dec 2016 09:44:59 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <586072E9.3060609@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 611 Lines: 13 On 12/25/2016 8:31 PM, Hanjun Guo wrote: >> A type->setup() would be somewhat cleaner I think, but then it's more >> code. Whichever works better I guess. :-) > Agree, I will demo the type->setup() way and send out the patch for review, > also I find one minor issue for the IORT code, will update that also for next > version. Can you provide details on what the minor issue is with the IORT code? -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.