Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752918AbcL2Q2R convert rfc822-to-8bit (ORCPT ); Thu, 29 Dec 2016 11:28:17 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:60377 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752848AbcL2Q2Q (ORCPT ); Thu, 29 Dec 2016 11:28:16 -0500 Date: Thu, 29 Dec 2016 17:28:14 +0100 From: Boris Brezillon To: Marek Vasut , Sudip Mukherjee Cc: Richard Weinberger , David Woodhouse , Brian Norris , Cyrille Pitchen , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Hauke Mehrtens Subject: Re: [PATCH] mtd: nand: xway: fix build failure Message-ID: <20161229172814.164145b3@bbrezillon> In-Reply-To: References: <1482481032-28043-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1717 Lines: 63 +Hauke Sudip, Marek, On Fri, 23 Dec 2016 10:07:23 +0100 Marek Vasut wrote: > On 12/23/2016 09:17 AM, Sudip Mukherjee wrote: > > The build of mips xway_defconfig was failing with the error: > > > > drivers/mtd/nand/xway_nand.c:235:1: warning: > > data definition has no type or storage class > > MODULE_DEVICE_TABLE(of, xway_nand_match); > > ^~~~~~~~~~~~~~~~~~~ > > drivers/mtd/nand/xway_nand.c:235:1: error: > > type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' > > [-Werror=implicit-int] > > > > It missed to include the header file. > > > > Signed-off-by: Sudip Mukherjee > > Acked-by: Marek Vasut Nack. Hauke already sent a fix for that one, and I'm about to queue it in my fixes-for-4.10 branch. Marek, if you want to ack these patches, please review [1] and [2]. Thanks, Boris [1]https://patchwork.ozlabs.org/patch/702880/ [2]https://patchwork.ozlabs.org/patch/702879/ > > > --- > > > > Build log of next-20161223 is at: > > https://travis-ci.org/sudipm-mukherjee/parport/jobs/186246753 > > > > This error will be fixed but it will now uncover the next error as the > > build goes on. > > > > drivers/mtd/nand/xway_nand.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/mtd/nand/xway_nand.c b/drivers/mtd/nand/xway_nand.c > > index 1f2948c..00168d6 100644 > > --- a/drivers/mtd/nand/xway_nand.c > > +++ b/drivers/mtd/nand/xway_nand.c > > @@ -7,6 +7,7 @@ > > * Copyright © 2016 Hauke Mehrtens > > */ > > > > +#include > > #include > > #include > > #include > > > >