Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753400AbcL2R1s (ORCPT ); Thu, 29 Dec 2016 12:27:48 -0500 Received: from anholt.net ([50.246.234.109]:50618 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752982AbcL2R1p (ORCPT ); Thu, 29 Dec 2016 12:27:45 -0500 From: Eric Anholt To: Michal Hocko Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-stable , "Robin H. Johnson" , Michal Nazarewicz , Vlastimil Babka , Marek Szyprowski Subject: Re: [PATCH] mm: Drop "PFNs busy" printk in an expected path. In-Reply-To: <20161229091256.GF29208@dhcp22.suse.cz> References: <20161229023131.506-1-eric@anholt.net> <20161229091256.GF29208@dhcp22.suse.cz> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Thu, 29 Dec 2016 09:27:42 -0800 Message-ID: <87wpeitzld.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2078 Lines: 45 --=-=-= Content-Type: text/plain Michal Hocko writes: > This has been already brought up > http://lkml.kernel.org/r/20161130092239.GD18437@dhcp22.suse.cz and there > was a proposed patch for that which ratelimited the output > http://lkml.kernel.org/r/20161130132848.GG18432@dhcp22.suse.cz resp. > http://lkml.kernel.org/r/robbat2-20161130T195244-998539995Z@orbis-terrarum.net > > then the email thread just died out because the issue turned out to be a > configuration issue. Michal indicated that the message might be useful > so dropping it completely seems like a bad idea. I do agree that > something has to be done about that though. Can we reconsider the > ratelimit thing? I agree that the rate of the message has gone up during 4.9 -- it used to be a few per second. However, if this is an expected path during normal operation, we shouldn't be clogging dmesg with it at all. So, I'd rather we go with this patch, that is unless the KERN_DEBUG in your ratelimit patch would keep it out of journald as well (un-ratelimited, journald was eating 10% of a CPU processing the message, and I'd rather it not be getting logged at all). --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlhlR44ACgkQtdYpNtH8 nuiJGBAApHDO41sS1UPZnr48HMD1xcfrxDwS8R2I97vTy8azBnwhonv9Vitv+7Kk hyvnPEi+EJ+XDsVgw7c/4GraU/CxOTlu4fOCLPDHzyyXjH2FPyMtPrUvTVsx44pZ SS5byt9vvZxgN+suxte8ursNcTEGGeDZ6hve6w47KSSQZJ1fxn35cIhrsqwuOeXB MlokpuTvyWpQ4Kup3MownB+YxyKPuYKvue8RPap90cEoe0N7NU/cBAZQQ1nO65kR ngL2g4i8Ho9YtLlnLOF8fUXvBdpKNvnPRo+ER4b3kLMZOkILizd4Zfvz17Z1ArgD ybFLCOFKHtWty7PvD5AtC2v2B5JX9JBO5cmWMACpXmLJ1hNCQrwecx/8fT/FY+NF UjNB4VkPgK8Qt55+JjwiYvF7aRz4FUVHioNophUYdO7A6BONul3zAlSSaLLtb5HZ bjA98xRwWrTUdhtPH/7VaglI1s27lv1ZVdyWImW5wgOYoBz0dwBZz6B2T29iijlw dWqBfFh+hfQ9UYSN2uRwcnBZWvMKKYDsAq8ae5exZs6TuM9O/7ubyE2IdnzGRk95 wys4IQ7eOA9t+f8XlaLpH56uj4VKgUsoSAqO4aOKTNhAqbKsJIoUVjZp9jyamjNt BOYg6v8k+L2N8qW/VZZxKBoyaC0aDNKO15u5oFIobCQPZgu4Lzk= =yK3q -----END PGP SIGNATURE----- --=-=-=--