Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753654AbcL3LTI (ORCPT ); Fri, 30 Dec 2016 06:19:08 -0500 Received: from mail-ua0-f195.google.com ([209.85.217.195]:34615 "EHLO mail-ua0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752395AbcL3LTG (ORCPT ); Fri, 30 Dec 2016 06:19:06 -0500 MIME-Version: 1.0 Reply-To: sedat.dilek@gmail.com In-Reply-To: <8737h7eykm.fsf@gaia.fi.intel.com> References: <20161227211329.GA8195@amd> <87r34sjw29.fsf@intel.com> <8737h7eykm.fsf@gaia.fi.intel.com> From: Sedat Dilek Date: Fri, 30 Dec 2016 12:19:04 +0100 Message-ID: Subject: Re: [Linux v4.10.0-rc1] call-traces after suspend-resume (pm? i915? cpu/hotplug?) To: Mika Kuoppala Cc: "Rafael J. Wysocki" , Jani Nikula , Pavel Machek , Thomas Gleixner , "Rafael J. Wysocki" , Daniel Vetter , Chris Wilson , intel-gfx , LKML , "the arch/x86 maintainers" , Linux PM Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4893 Lines: 129 On Thu, Dec 29, 2016 at 12:58 PM, Mika Kuoppala wrote: > Sedat Dilek writes: > >> On Wed, Dec 28, 2016 at 11:32 PM, Rafael J. Wysocki wrote: >>> On Wed, Dec 28, 2016 at 11:00 AM, Sedat Dilek wrote: >>>> On Wed, Dec 28, 2016 at 9:29 AM, Jani Nikula wrote: >>>>> On Wed, 28 Dec 2016, Sedat Dilek wrote: >>>>>> On Tue, Dec 27, 2016 at 10:13 PM, Pavel Machek wrote: >>>>>>> Hi! >>>>>>> >>>>>>>> [ Add some pm | i915 | x86 folks ] >>>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> I have built Linux v4.10-rc1 today on my Ubuntu/precise AMD64 system >>>>>>>> and I see some call-traces. >>>>>>>> It is reproducible on suspend and resume. >>>>>>>> >>>>>>>> I cannot say which area touches the problem or if these are several >>>>>>>> independent problems. >>>>>>>> >>>>>>>> For a full dmesg-log see attachments (my linux-config is attached, too). >>>>>>>> >>>>>>>> Here some hunks... >>>>>>>> >>>>>>>> [ 29.003601] BUG: sleeping function called from invalid context at >>>>>>>> drivers/base/power/runtime.c:1032 >>>>>>>> [ 29.003608] in_atomic(): 1, irqs_disabled(): 0, pid: 1469, name: Xorg >>>>>>>> [ 29.003610] 1 lock held by Xorg/1469: >>>>>>>> [ 29.003611] #0: (&dev->struct_mutex){+.+.+.}, at: >>>>>>>> [] i915_mutex_lock_interruptible+0x43/0x140 [i915] >>>>>>>> [ 29.003653] CPU: 0 PID: 1469 Comm: Xorg Not tainted >>>>>>>> 4.10.0-rc1-1-iniza-small #1 >>>>>>>> [ 29.003655] Hardware name: SAMSUNG ELECTRONICS CO., LTD. >>>>>>>> 530U3BI/530U4BI/530U4BH/530U3BI/530U4BI/530U4BH, BIOS 13XK 03/28/2013 >>>>>>>> [ 29.003656] Call Trace: >>>>>>> >>>>>>> Just a note, at least 2 machines here refuse to resume with >>>>>>> v4.10-rc1. One has intel graphics, one has AMD. It may or may not have >>>>>>> common cause... >>>>>>> >>>>>> >>>>>> [ Correct linux-pm ML and add Mika & Jani ] >>>>>> >>>>>> Thanks for the feedback. >>>>>> >>>>>> There are some cpu/hotplug fixes post-v4.10-rc1. >>>>>> Give that a try. >>>>>> >>>>>> Yesterday, after answers from drm-intel folks I have seen that a >>>>>> cpu/hotplug commit [1] was reverted in >>>>>> drm-intel.git#drm-intel-nightly. >>>>>> I haven't tried that. >>>>>> >>>>>> It's good when Thomas knows of this and gets in contact with drm-intel folks. >>>>>> >>>>>> Regards, >>>>>> - Sedat - >>>>>> >>>>>> [1] https://cgit.freedesktop.org/drm-intel/commit/?h=drm-intel-nightly&id=e558f178f5390185b7324ff4b816b52c6ae3a928 >>>>>> [2] https://cgit.freedesktop.org/drm-intel/log/?h=drm-intel-nightly >>>>>> >>>>>> P.S.: Revert "cpu/hotplug: Prevent overwriting of callbacks" >>>>>> >>>>>> This reverts commit dc280d93623927570da279e99393879dbbab39e7 >>>>>> Author: Thomas Gleixner >>>>>> Date: Wed Dec 21 20:19:49 2016 +0100 >>>>>> cpu/hotplug: Prevent overwriting of callbacks >>>>>> >>>>>> It started hanging all machines in CI s3 test: >>>>>> https://intel-gfx-ci.01.org/CI/igt@gem_exec_suspend@basic-s3.html >>>>>> >>>>>> Bisected-by: Mika Kuoppala >>>>>> Signed-off-by: Jani Nikula >>>>> >>>>> Thomas - >>>>> >>>>> Indeed, basically all of the boxes in the intel-gfx CI hang at the >>>>> suspend/resume test with dc280d936239 ("cpu/hotplug: Prevent overwriting >>>>> of callbacks"), and after the revert in the tree that feeds to the CI, >>>>> we're back on track. >>>>> >>>>> I found [1], was hoping to get feedback from Mika whether that helps >>>>> before reporting. Chris also suggested [2] as a quick fix but I don't >>>>> know if anyone tried that. >>>>> >>>> >>>> Hi Jani, >>>> >>>> I know you were not CCed in the original thread, please see [5]. >>>> >>>> The patchset from Thomas you mention [1] does fix one of the problems >>>> I have seen, please see [6]. >>>> With these post-v4.10-rc1 patches applied a clean revert of Revert >>>> "cpu/hotplug: Prevent overwriting of callbacks" is not possible. >>>> >>>> Can you give a clear statement if the quick-fix from Chris is in >>>> combination with the above revert or not? >>>> Against v4.10-rc1? >>>> Tested together with the patchset of Thomas? >>> >>> Please test the Linus' tree from today, it should work. >>> >> >> Latest Linus tree (v4.10-rc1-17-g2d706e790f05) does not fix it. >> > > Latest Linus tree 2d706e790f0508dff4fb72eca9b4892b79757feb fixes our S3 > problems. It survives gem_exec_suspend --r basic-S3 on kabylake. > > It contains the fix to the bisected commit: > > commit b9d9d6911bd5c370ad4b3aa57d758c093d17aed5 > Author: Thomas Gleixner > Date: Mon Dec 26 22:58:19 2016 +0100 > > smp/hotplug: Undo tglxs brainfart > > These are good news! I still see another issue and this seems independent of Thomas' "brainfart" patch. Will post a separate email on the other issue. - Sedat -