Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754060AbcL3NC7 (ORCPT ); Fri, 30 Dec 2016 08:02:59 -0500 Received: from mail-qt0-f177.google.com ([209.85.216.177]:33792 "EHLO mail-qt0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753848AbcL3NC6 (ORCPT ); Fri, 30 Dec 2016 08:02:58 -0500 MIME-Version: 1.0 In-Reply-To: <87o9zvw69a.fsf@belgarion.home> References: <1481207730-6332-1-git-send-email-arvind.yadav.cs@gmail.com> <87o9zvw69a.fsf@belgarion.home> From: Linus Walleij Date: Fri, 30 Dec 2016 14:02:56 +0100 Message-ID: Subject: Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions To: Robert Jarzmik Cc: Arvind Yadav , Daniel Mack , Haojian Zhuang , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 902 Lines: 26 On Thu, Dec 29, 2016 at 8:20 AM, Robert Jarzmik wrote: > Linus Walleij writes: > >> On Thu, Dec 8, 2016 at 3:35 PM, Arvind Yadav wrote: >> >>> In functions pxa2xx_build_functions, the memory allocated for >>> 'functions' is live within the function only. After the >>> allocation it is immediately freed with devm_kfree. There is >>> no need to allocate memory for 'functions' with devm function >>> so replace devm_kcalloc with kcalloc and devm_kfree with kfree. >>> >>> Signed-off-by: Arvind Yadav >> >> I want the maintainer Robert Jarzmik to review this before I do anything > > Hi Linus, > > I did review, on December the 10th. I wasn't very enthusiastic about the patch, > if you check back my reply. Sorry I missed it (mail overload as usual). OK dropping this. Yours, Linus Walleij