Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754120AbcL3Nae (ORCPT ); Fri, 30 Dec 2016 08:30:34 -0500 Received: from gofer.mess.org ([80.229.237.210]:38849 "EHLO gofer.mess.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753938AbcL3Nac (ORCPT ); Fri, 30 Dec 2016 08:30:32 -0500 Date: Fri, 30 Dec 2016 13:30:30 +0000 From: Sean Young To: Ivaylo Dimitrov Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Timo Kokkonen , Pavel Machek , Pali =?iso-8859-1?Q?Roh=E1r?= Subject: Re: [PATCH 1/5] [media] ir-rx51: port to rc-core Message-ID: <20161230133030.GA7861@gofer.mess.org> References: <5878d916-6a60-d5c3-b912-948b5b970661@gmail.com> <20161230130752.GA7377@gofer.mess.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161230130752.GA7377@gofer.mess.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1335 Lines: 39 On Fri, Dec 30, 2016 at 01:07:52PM +0000, Sean Young wrote: > Hi Ivo,, > > On Fri, Dec 30, 2016 at 01:30:01PM +0200, Ivaylo Dimitrov wrote: > > On 20.12.2016 19:50, Sean Young wrote: > > >This driver was written using lirc since rc-core did not support > > >transmitter-only hardware at that time. Now that it does, port > > >this driver. > > > > > >Compile tested only. > > > > > > > I guess after that change, there will be no more /dev/lircN device, right? > > Neither will LIRC_XXX IOCTL codes be supported? > > Quite the opposite, /dev/lircN and all the LIRC_XXX ioctls will still be > supported through ir-lirc-codec.c. > > By using rc-core, the driver will be more succinct, and some latent bugs > will be fixed. For example, at the moment it is possible to write hours > of IR data and keep the n900 from suspending. > > I'm working on lirc scancode sending and receiving using the IR encoders, > and when that is in place, any rc-core driver will get it for free. > > > That looks to me as a completely new driver, not a port to new API. > > > > Right now there are applications using the current behaviour (pierogi for > > example), which will be broken by the change. > > Nothing should break. Speaking of which, if you would please test this, that would be great. My N900 died many years ago. Many thanks, Sean