Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754111AbcL3Nqe (ORCPT ); Fri, 30 Dec 2016 08:46:34 -0500 Received: from mail-qk0-f170.google.com ([209.85.220.170]:36326 "EHLO mail-qk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754044AbcL3Nqb (ORCPT ); Fri, 30 Dec 2016 08:46:31 -0500 MIME-Version: 1.0 In-Reply-To: <20161227172003.6517-2-tony@atomide.com> References: <20161227172003.6517-1-tony@atomide.com> <20161227172003.6517-2-tony@atomide.com> From: Linus Walleij Date: Fri, 30 Dec 2016 14:46:30 +0100 Message-ID: Subject: Re: [PATCH 1/5] pinctrl: core: Use delayed work for hogs To: Tony Lindgren Cc: Haojian Zhuang , Masahiro Yamada , Grygorii Strashko , Nishanth Menon , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linux-OMAP Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 922 Lines: 22 On Tue, Dec 27, 2016 at 6:19 PM, Tony Lindgren wrote: > Having the pin control framework call pin controller functions > before it's probe has finished is not nice as the pin controller > device driver does not yet have struct pinctrl_dev handle. > Let's fix this issue by adding deferred work for late init. This is > needed to be able to add pinctrl generic helper functions that expect > to know struct pinctrl_dev handle. Note that we now need to call > create_pinctrl() directly as we don't want to add the pin controller > to the list of controllers until the hogs are claimed. We also need > to pass the pinctrl_dev to the device tree parser functions as they > otherwise won't find the right controller at this point. > > Signed-off-by: Tony Lindgren Patch applied. I felt the code path needed some extra comments so I sent those as a separate patch. Yours, Linus Walleij