Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752056AbcL3Raa (ORCPT ); Fri, 30 Dec 2016 12:30:30 -0500 Received: from mx2.suse.de ([195.135.220.15]:60490 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750962AbcL3Ra3 (ORCPT ); Fri, 30 Dec 2016 12:30:29 -0500 Date: Fri, 30 Dec 2016 18:30:24 +0100 From: Michal Hocko To: Minchan Kim Cc: Hillf Danton , linux-mm@kvack.org, Andrew Morton , Mel Gorman , Johannes Weiner , Vlastimil Babka , Rik van Riel , LKML Subject: Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint Message-ID: <20161230173023.GA4962@dhcp22.suse.cz> References: <20161228153032.10821-1-mhocko@kernel.org> <20161228153032.10821-3-mhocko@kernel.org> <20161229053359.GA1815@bbox> <20161229075243.GA29208@dhcp22.suse.cz> <20161230014853.GA4184@bbox> <20161230092636.GA13301@dhcp22.suse.cz> <20161230160456.GA7267@bbox> <20161230163742.GK13301@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161230163742.GK13301@dhcp22.suse.cz> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 893 Lines: 21 On Fri 30-12-16 17:37:42, Michal Hocko wrote: > On Sat 31-12-16 01:04:56, Minchan Kim wrote: [...] > > > - nr_rotated pages which tells us that we are hitting referenced > > > pages which are deactivated. If this is a large part of the > > > reported nr_deactivated pages then the active list is too small > > > > It might be but not exactly. If your goal is to know LRU size, it can be > > done in get_scan_count. I tend to agree LRU size is helpful for > > performance analysis because decreased LRU size signals memory shortage > > then performance drop. > > No, I am not really interested in the exact size but rather to allow to > find whether we are aging the active list too early... But thinking about that some more, maybe sticking with the nr_rotated terminology is rather confusing and displaying the value as nr_referenced would be more clear. -- Michal Hocko SUSE Labs