Message-ID: <1483145368.1955.6.camel@perches.com>
Subject: Re: [PATCH] This continues from this commit: 52f5684c8e1e ("kernel:
 use macros from compiler.h instead of __attribute__((...))")
From: Joe Perches <joe@perches.com>
To: gidisrael@gmail.com, herbert@gondor.apana.org.au, davem@davemloft.net,
        nhorman@tuxdriver.com, akpm@linux-foundation.org, geert@linux-m68k.org,
        linux-kernel@vger.kernel.org
Date: Fri, 30 Dec 2016 16:49:28 -0800
In-Reply-To: <1483144873-2932-1-git-send-email-gidisrael@gmail.com>
References: <1483144873-2932-1-git-send-email-gidisrael@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1662
Lines: 43

On Sat, 2016-12-31 at 06:11 +0530, gidisrael@gmail.com wrote:
> There is <linux/compiler.h> which provides macros for various gcc specific
> constructs. Eg: __weak for __attribute__((weak)). I've cleaned all
> instances of gcc specific attributes with the right macros for the crypto
> subsystem.
[]
> diff --git a/crypto/ablkcipher.c b/crypto/ablkcipher.c
[]
> @@ -394,7 +395,7 @@ static int crypto_ablkcipher_report(struct sk_buff *skb, struct crypto_alg *alg)
>  #endif
>  
>  static void crypto_ablkcipher_show(struct seq_file *m, struct crypto_alg *alg)
> -	__attribute__ ((unused));
> +	__always_unused;
>  static void crypto_ablkcipher_show(struct seq_file *m, struct crypto_alg *alg)
>  {
>  	struct ablkcipher_alg *ablkcipher = &alg->cra_ablkcipher;
> @@ -468,7 +469,7 @@ static int crypto_givcipher_report(struct sk_buff *skb, struct crypto_alg *alg)
>  #endif
>  
>  static void crypto_givcipher_show(struct seq_file *m, struct crypto_alg *alg)
> -	__attribute__ ((unused));
> +	__always_unused;
>  static void crypto_givcipher_show(struct seq_file *m, struct crypto_alg *alg)
>  {
>  	struct ablkcipher_alg *ablkcipher = &alg->cra_ablkcipher;

Perhaps it'd be better to remove the declaration/prototype
of crypto_ablkcipher_show and surround the definition of
crypto_ablkcipher_show with #ifdef CONFIG_PROC_FS / #endif

[]

> diff --git a/crypto/acompress.c b/crypto/acompress.c
[]
> @@ -50,7 +51,7 @@ static int crypto_acomp_report(struct sk_buff *skb, struct crypto_alg *alg)
>  #endif
>  
>  static void crypto_acomp_show(struct seq_file *m, struct crypto_alg *alg)
> -	__attribute__ ((unused));
> +	__always_unused;

likewise and for others too.