Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754596AbcLaBik (ORCPT ); Fri, 30 Dec 2016 20:38:40 -0500 Received: from mail-ua0-f176.google.com ([209.85.217.176]:35334 "EHLO mail-ua0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754369AbcLaBii (ORCPT ); Fri, 30 Dec 2016 20:38:38 -0500 MIME-Version: 1.0 In-Reply-To: <20161230155634.8692-3-dsafonov@virtuozzo.com> References: <20161230155634.8692-1-dsafonov@virtuozzo.com> <20161230155634.8692-3-dsafonov@virtuozzo.com> From: Andy Lutomirski Date: Fri, 30 Dec 2016 17:38:17 -0800 Message-ID: Subject: Re: [RFC 2/4] x86/thread_info: kill TIF_ADDR32 in favour of ADDR_LIMIT_32BIT To: Dmitry Safonov Cc: "linux-kernel@vger.kernel.org" , Dmitry Safonov <0x7f454c46@gmail.com>, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Andy Lutomirski , "Kirill A. Shutemov" , X86 ML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 627 Lines: 11 On Fri, Dec 30, 2016 at 7:56 AM, Dmitry Safonov wrote: > This thread flag is completely x86-specific, consolidate it with > ADDR_LIMIT_32BIT personality which is defined but not used on x86. > It will free one of thread flags and consolidate personality with > other arches. > After this commit ADDR_LIMIT_32BIT is set by the kernel automatically > in COMPAT_SET_PERSONALITY() for 32-bit ELF files and for 32-bit a.out. > It's cleared in SET_PERSONALITY() for 64-bit ELFs. I'm okay with this as a plain cleanup, but I'm not convinced that this is really the right long-term solution. See next email.