Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754609AbcLaJEA (ORCPT ); Sat, 31 Dec 2016 04:04:00 -0500 Received: from helcar.hengli.com.au ([209.40.204.226]:34273 "EHLO helcar.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753005AbcLaJD5 (ORCPT ); Sat, 31 Dec 2016 04:03:57 -0500 Date: Sat, 31 Dec 2016 17:03:25 +0800 From: Herbert Xu To: Joe Perches Cc: gidisrael@gmail.com, davem@davemloft.net, nhorman@tuxdriver.com, akpm@linux-foundation.org, geert@linux-m68k.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] This continues from this commit: 52f5684c8e1e ("kernel: use macros from compiler.h instead of __attribute__((...))") Message-ID: <20161231090325.GA16976@gondor.apana.org.au> References: <1483144873-2932-1-git-send-email-gidisrael@gmail.com> <1483145368.1955.6.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1483145368.1955.6.camel@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 463 Lines: 11 On Fri, Dec 30, 2016 at 04:49:28PM -0800, Joe Perches wrote: > > Perhaps it'd be better to remove the declaration/prototype > of crypto_ablkcipher_show and surround the definition of > crypto_ablkcipher_show with #ifdef CONFIG_PROC_FS / #endif No that's stupid. We want to maximise the compiler coverage. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt