Message-ID: <1483201880.1955.10.camel@perches.com>
Subject: Re: [PATCH] This continues from this commit: 52f5684c8e1e ("kernel:
 use macros from compiler.h instead of __attribute__((...))")
From: Joe Perches <joe@perches.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: gidisrael@gmail.com, davem@davemloft.net, nhorman@tuxdriver.com,
        akpm@linux-foundation.org, geert@linux-m68k.org,
        linux-kernel@vger.kernel.org
Date: Sat, 31 Dec 2016 08:31:20 -0800
In-Reply-To: <20161231090325.GA16976@gondor.apana.org.au>
References: <1483144873-2932-1-git-send-email-gidisrael@gmail.com>
         <1483145368.1955.6.camel@perches.com>
         <20161231090325.GA16976@gondor.apana.org.au>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 485
Lines: 13

On Sat, 2016-12-31 at 17:03 +0800, Herbert Xu wrote:
> On Fri, Dec 30, 2016 at 04:49:28PM -0800, Joe Perches wrote:
> > 
> > Perhaps it'd be better to remove the declaration/prototype
> > of crypto_ablkcipher_show and surround the definition of
> > crypto_ablkcipher_show with #ifdef CONFIG_PROC_FS / #endif
> 
> No that's stupid.  We want to maximise the compiler coverage.

stupid is rather a strong word for the most
common technique used in the kernel to avoid
compiler warnings.