Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754781AbcLaSsn (ORCPT ); Sat, 31 Dec 2016 13:48:43 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:34625 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754690AbcLaSsm (ORCPT ); Sat, 31 Dec 2016 13:48:42 -0500 Subject: Re: [PATCH v3] net: ethernet: faraday: To support device tree usage. To: Greentime Hu , netdev@vger.kernel.org, devicetree@vger.kernel.org, andrew@lunn.ch, arnd@arndb.de, linux-kernel@vger.kernel.org, jiri@resnulli.us References: <1483083470-15779-1-git-send-email-green.hu@gmail.com> From: Florian Fainelli Message-ID: <351d1ae7-ca51-7962-0e52-38cdc69bcebd@gmail.com> Date: Sat, 31 Dec 2016 10:48:39 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1483083470-15779-1-git-send-email-green.hu@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 350 Lines: 12 On 12/29/2016 11:37 PM, Greentime Hu wrote: > Signed-off-by: Greentime Hu This is not enough, you need to add a Device Tree binding document under Documentation/devicetree/bindings/net/ which documents this compatible string, as well as additional properties that may be required to describe this hardware block. -- Florian