Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751989AbdCAHbw (ORCPT ); Wed, 1 Mar 2017 02:31:52 -0500 Received: from mga04.intel.com ([192.55.52.120]:4052 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751824AbdCAHbZ (ORCPT ); Wed, 1 Mar 2017 02:31:25 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,224,1484035200"; d="scan'208";a="54340622" From: "Loh, Tien Hock" To: "arnd@arndb.de" CC: "linux-kernel@vger.kernel.org" , "Nguyen, Dinh" , "thloh85@gmail.com" , "gregkh@linuxfoundation.org" , "Gerlach, Matthew" Subject: Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver Thread-Topic: [PATCH 1/1] drivers/misc: Add Intel System ID driver Thread-Index: AQHSh3xEV1UiWY2US02NwdEQuVXhNaFpybMAgAArIICAC6nLgIAAI4+AgAACs4CACV+bAA== Date: Wed, 1 Mar 2017 07:23:55 +0000 Message-ID: <1488353034.3544.3.camel@intel.com> References: <1487156981-4550-1-git-send-email-user@thloh-VirtualBox> <20170215171732.GA4548@kroah.com> <1487829507.2961.5.camel@intel.com> <1487837723.2961.7.camel@intel.com> In-Reply-To: <1487837723.2961.7.camel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.226.241.207] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v217W2eG012685 Content-Length: 2053 Lines: 64 Arnd, Greg, I checked the attributes returned by the soc attribute subsystem, but it seems that it is lacking something equivalent to timestamp in the Intel System ID controller. Do you think it is better to add a new attribute (named timestamp) to soc or create a new sysfs entry like what I did? Thanks Tien Hock  On Kha, 2017-02-23 at 16:15 +0800, Loh, Tien Hock wrote: > OK then I'll move it into driver/soc/ in that case. > > On Kha, 2017-02-23 at 09:05 +0100, Arnd Bergmann wrote: > > > > On Thu, Feb 23, 2017 at 6:58 AM, Loh, Tien Hock > l. > > com> wrote: > > > > > > > > > On Rab, 2017-02-15 at 20:51 +0100, Arnd Bergmann wrote: > > > > > > > > > > > > On Wed, Feb 15, 2017 at 6:17 PM, Greg KH > > > n. > > > > org> > > > > wrote: > > > > > > > > > > > > > > > > > > > > On Wed, Feb 15, 2017 at 07:09:41PM +0800, thloh wrote: > > > > > > > > > > > > > > > > > > > > > > > > From: "Loh, Tien Hock" > > > > > > > > > > > > This patch is to add Altera System ID driver. > > > > > > User can obtain the system ID and timestamp of the system > > > > > > by > > > > > > reading the sysfs entry. > > > > > > > > > > > > Usage: > > > > > > cat /sys/bus/platform/devices/[addr].sysid/sysid/id > > > > > > cat /sys/bus/platform/devices/[addr].sysid/sysid/timestamp > > > > > If you add new sysfs attributes, you need to also add a > > > > > Documentation/ABI/ description as well. > > > > Maybe we could pretend that this is for a SoC and use the > > > > standard > > > > soc_device > > > > attributes as well as moving the driver into drivers/soc/?> > > > > Sorry > > > > for the late reply. > > > This driver can currently be used by ARM and Nios II, so moving > > > it > > > into > > > drivers/soc might not be the best idea. > > Why not? drivers/soc/ was specifically introduced for stuff that is > > used on > > some SoC but across more than one architecture (otherwise it would > > be > > in arch/foo/). This seems to fit perfectly. > > > >      Arnd