Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751957AbdCAHwS (ORCPT ); Wed, 1 Mar 2017 02:52:18 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:35788 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751009AbdCAHwP (ORCPT ); Wed, 1 Mar 2017 02:52:15 -0500 Date: Wed, 1 Mar 2017 08:51:22 +0100 From: Greg KH To: "Pranay Kr. Srivastava" Cc: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca, samuel.thibault@ens-lyon.org, sfr@canb.auug.org.au, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH SPEAKUP v2 1/3] return same error value from spk_set_key_info Message-ID: <20170301075122.GA15340@kroah.com> References: <20170228082755.53396-1-pranjas@gmail.com> <20170228082755.53396-2-pranjas@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170228082755.53396-2-pranjas@gmail.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 780 Lines: 23 On Tue, Feb 28, 2017 at 01:57:53PM +0530, Pranay Kr. Srivastava wrote: > This patch makes spk_set_key_info return -EINVAL > in case of failure instead of returning 4 different > values for the type of error that occurred. > > Print the offending values instead as debug message. > > Signed-off-by: Pranay Kr. Srivastava > --- > drivers/staging/speakup/main.c | 27 +++++++++++++++++++-------- > 1 file changed, 19 insertions(+), 8 deletions(-) Please fix up your subject line to contain the subsystem and driver it is modifying. For example, this message should read: Subject: staging: speakup: return same error value from spk_set_key_info Same thing goes for all 3 messages in this series. Please fix up, keep the Ack, and resend. thanks, greg k-h