Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752084AbdCAIm7 convert rfc822-to-8bit (ORCPT ); Wed, 1 Mar 2017 03:42:59 -0500 Received: from terminus.zytor.com ([65.50.211.136]:43260 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751099AbdCAIm5 (ORCPT ); Wed, 1 Mar 2017 03:42:57 -0500 Date: Wed, 01 Mar 2017 00:15:38 -0800 User-Agent: K-9 Mail for Android In-Reply-To: References: <20170301060504.oltm3iws6fmubnom@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Subject: Re: [tip:core/urgent] objtool: Fix __unreachable section relocation size To: linux-tip-commits@vger.kernel.org, tip-bot for Josh Poimboeuf CC: a.p.zijlstra@chello.nl, torvalds@linux-foundation.org, jpoimboe@redhat.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@kernel.org From: hpa@zytor.com Message-ID: <1A185271-A629-43C0-9A1B-9EDB75630057@zytor.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2155 Lines: 62 On March 1, 2017 12:10:59 AM PST, tip-bot for Josh Poimboeuf wrote: >Commit-ID: 90a7e63a31b8f7d630d12ef0d8d37d3ab87f76e5 >Gitweb: >http://git.kernel.org/tip/90a7e63a31b8f7d630d12ef0d8d37d3ab87f76e5 >Author: Josh Poimboeuf >AuthorDate: Wed, 1 Mar 2017 00:05:04 -0600 >Committer: Ingo Molnar >CommitDate: Wed, 1 Mar 2017 07:38:25 +0100 > >objtool: Fix __unreachable section relocation size > >Linus reported the following commit broke module loading on his laptop: > >d1091c7fa3d5 ("objtool: Improve detection of BUG() and other dead >ends") > >It showed errors like the following: > > module: overflow in relocation type 10 val ffffffffc02afc81 > module: 'nvme' likely not compiled with -mcmodel=kernel > >The problem is that the __unreachable section addresses are stored >using >the '.long' asm directive, which isn't big enough for .text section >relative kernel addresses. Use '.quad' instead. > >Suggested-by: Linus Torvalds >Reported-by: Linus Torvalds >Signed-off-by: Josh Poimboeuf >Cc: Peter Zijlstra >Cc: Peter Zijlstra >Cc: Thomas Gleixner >Fixes: d1091c7fa3d5 ("objtool: Improve detection of BUG() and other >dead ends") >Link: http://lkml.kernel.org/r/20170301060504.oltm3iws6fmubnom@treble >Signed-off-by: Ingo Molnar >--- > include/linux/compiler-gcc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/include/linux/compiler-gcc.h >b/include/linux/compiler-gcc.h >index 76e28c2..91a77a5 100644 >--- a/include/linux/compiler-gcc.h >+++ b/include/linux/compiler-gcc.h >@@ -201,7 +201,7 @@ > #define annotate_unreachable() ({ \ > asm("%c0:\t\n" \ > ".pushsection __unreachable, \"a\"\t\n" \ >- ".long %c0b\t\n" \ >+ ".quad %c0b\t\n" \ > ".popsection\t\n" : : "i" (__LINE__)); \ > }) > #else Or perhaps better use relative addresses, so: .long foo - (.+4) -- Sent from my Android device with K-9 Mail. Please excuse my brevity.