Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751917AbdCAJDX (ORCPT ); Wed, 1 Mar 2017 04:03:23 -0500 Received: from mail-oi0-f49.google.com ([209.85.218.49]:34227 "EHLO mail-oi0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750993AbdCAJDO (ORCPT ); Wed, 1 Mar 2017 04:03:14 -0500 MIME-Version: 1.0 In-Reply-To: <1488353034.3544.3.camel@intel.com> References: <1487156981-4550-1-git-send-email-user@thloh-VirtualBox> <20170215171732.GA4548@kroah.com> <1487829507.2961.5.camel@intel.com> <1487837723.2961.7.camel@intel.com> <1488353034.3544.3.camel@intel.com> From: Arnd Bergmann Date: Wed, 1 Mar 2017 10:01:36 +0100 X-Google-Sender-Auth: pMfWgH8qTZXzdLOFpqjGO-va-UQ Message-ID: Subject: Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver To: "Loh, Tien Hock" Cc: "linux-kernel@vger.kernel.org" , "Nguyen, Dinh" , "thloh85@gmail.com" , "gregkh@linuxfoundation.org" , "Gerlach, Matthew" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1227 Lines: 29 On Wed, Mar 1, 2017 at 8:23 AM, Loh, Tien Hock wrote: > Arnd, Greg, Please don't top-post. > I checked the attributes returned by the soc attribute subsystem, but > it seems that it is lacking something equivalent to timestamp in the > Intel System ID controller. Do you think it is better to add a new > attribute (named timestamp) to soc or create a new sysfs entry like > what I did? It depends on how common and how important this attribute is. - if it's not overly important, just drop it entirely. - if it's important enough that other SoCs are likely to have the same kind of information, make it a standard attribute - if this SoC is most likely the only one that will ever need it, but it has important uses, I'd make it a custom attribute Another option would be to fold the timestamp into the revision attribute, but whether that is a reasonable place for it would in turn depend on what the timestamp signifies. Can you explain what the timestamp is used for? Does it identify the time that the hardware revision was made, the time that a software was built which was loaded into it, or something else? What kind of user space application would need this information? Arnd