Subject: Re: [PATCH 1/2] vfs: implement fchmodat2() syscall
To: Greg Kurz <groug@kaod.org>
References: <148830142269.7103.7429913851447595016.stgit@bahia>
 <99466bd0-48f2-1594-5392-5e6191d56ffa@redhat.com>
 <20170228194148.115674bc@bahia.lan>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
From: Eric Blake <eblake@redhat.com>
Openpgp: url=http://people.redhat.com/eblake/eblake.gpg
Organization: Red Hat, Inc.
Message-ID: <38b0d8a4-a87e-a561-a666-a573dc232108@redhat.com>
Date: Tue, 28 Feb 2017 12:59:41 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <20170228194148.115674bc@bahia.lan>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="xnJc5eJQVr2nCSaJ1aAPlu4u10jsAJb8v"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2929
Lines: 74

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--xnJc5eJQVr2nCSaJ1aAPlu4u10jsAJb8v
Content-Type: multipart/mixed; boundary="EDHOiMP07OuDboiQAbKBpfTf8vrQ0hqHF";
 protected-headers="v1"
From: Eric Blake <eblake@redhat.com>
To: Greg Kurz <groug@kaod.org>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
 linux-kernel@vger.kernel.org
Message-ID: <38b0d8a4-a87e-a561-a666-a573dc232108@redhat.com>
Subject: Re: [PATCH 1/2] vfs: implement fchmodat2() syscall
References: <148830142269.7103.7429913851447595016.stgit@bahia>
 <99466bd0-48f2-1594-5392-5e6191d56ffa@redhat.com>
 <20170228194148.115674bc@bahia.lan>
In-Reply-To: <20170228194148.115674bc@bahia.lan>

--EDHOiMP07OuDboiQAbKBpfTf8vrQ0hqHF
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 02/28/2017 12:41 PM, Greg Kurz wrote:

>>> +++ b/include/linux/syscalls.h
>>> @@ -775,6 +775,8 @@ asmlinkage long sys_futimesat(int dfd, const char=
 __user *filename,
>>>  asmlinkage long sys_faccessat(int dfd, const char __user *filename, =
int mode);
>>>  asmlinkage long sys_fchmodat(int dfd, const char __user * filename,
>>>  			     umode_t mode);
>>> +asmlinkage long sys_fchmodat2(int dfd, const char __user *filename,
>>> +			      umode_t mode, int flag);
>>>  asmlinkage long sys_fchownat(int dfd, const char __user *filename, u=
id_t user,
>>>  			     gid_t group, int flag); =20
>>
>> Is the indentation off here?
>>
>=20
> This is linux style indent with tabs+spaces. FWIW it is displayed corre=
ctly
> in vi and emacs (I've simply copied the sys_fchmodat() declaration).

Sorry for the noise; I see that it is correct now, since fchmodat2 is
one bye longer than fchmodat or fchownat.  Sometimes, I wish I could
convince my mailer to display leading tabs as exactly 8 spaces rather
than to the next 8-space tab stop, so that prefixed characters that
aren't tab-stop aligned don't mess with the actual visual output.

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--EDHOiMP07OuDboiQAbKBpfTf8vrQ0hqHF--

--xnJc5eJQVr2nCSaJ1aAPlu4u10jsAJb8v
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJYtcidAAoJEKeha0olJ0NqwloH/1lctHQ8ZZvvD01DVECnU1kw
VOb6bbwOw3wN+ceDmWvuVUSRNDapFAGTm/dp4bZmzFr56iOY76xd/ZGD4J18ZmS4
hOUvlR0RMTY0fvPjDU9gm/YIiuPCV23EMegz0j6o4RF2koBksy7Zi+kjT9ZYHU6n
lo2E0GgOifnDu1EHbyCuhO2LS3feD+cjfc6wLhl65UeiHdecTt6uylBfcWv6DtHn
k8iYdVYNI3oAmwC5uTQ2Im2vGcEB3VCQrXNP910oI9sm5EJVfS5fAasPLvwNx8v4
egabtVLQcfoXZ/7hNGrFVGuLjOFZps0h3avrbPB+csDHCTN/yybAmAme1hMzAbo=
=W4C6
-----END PGP SIGNATURE-----

--xnJc5eJQVr2nCSaJ1aAPlu4u10jsAJb8v--