Subject: Re: [GIT PULL] HID for 4.11
To: Linus Torvalds <torvalds@linux-foundation.org>,
        Peter Hutterer <peter.hutterer@who-t.net>
References: <alpine.LSU.2.20.1702201508280.24579@cbobk.fhfr.pm>
 <CA+55aFxLmgA7drrGfUJmCRPT-A74ROYf6GQHFGO5pzVjZ0dL7Q@mail.gmail.com>
 <CA+55aFzLGosGoB5STrAampHPQ9H-K7v08N2Jx9ETsHnMFgv+=A@mail.gmail.com>
 <CA+55aFzfUbcB44UYwbKv-qci-wxCsWKEZs4Mso-J5cCoz9x0qQ@mail.gmail.com>
 <CA+55aFwQ44nWc5OJmDhjP0DU==u6aqQGg4TErivBKvR=JQyDkg@mail.gmail.com>
 <CA+55aFwk5726yuZhxQ9OCQBK3M-W0stKh8PueHtVaR=eJzF3Rg@mail.gmail.com>
 <c8bdecc1-f098-dfdb-3f86-0522fcba6954@synaptics.com>
 <20170301032409.GA8206@jelly>
 <CA+55aFxeX5SW7kki=wqAhDfxtzuDG0xach7f5eOgJCD8drLuFA@mail.gmail.com>
CC: Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>
From: Andrew Duggan <aduggan@synaptics.com>
Message-ID: <06556567-7a6a-5d40-ce4a-1c408956e51e@synaptics.com>
Date: Tue, 28 Feb 2017 23:43:08 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <CA+55aFxeX5SW7kki=wqAhDfxtzuDG0xach7f5eOgJCD8drLuFA@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2017 07:43:12.2568 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB2041
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1401
Lines: 28


On 02/28/2017 09:05 PM, Linus Torvalds wrote:
> On Tue, Feb 28, 2017 at 7:24 PM, Peter Hutterer
> <peter.hutterer@who-t.net> wrote:
>> I suspect you're just triggering a bug that wasn't triggered by the ps/2
>> emulation. you can run linput-debug-events --verbose and have a look at the
>> various state debugging information, that may hint at what's going on (e.g.
>> a finger mistaken as palm touch, or something). Or record one such
>> interaction with evemu-record and send it to me (preferrably here [1], if
>> you're using libinput). Also, what version of libinput/synaptics are you on?
> bug reported (it's bug 100014).
>
> This is libinput-1.5.4 on Fedora 24. I attached both the
> libinput-debug-events output as well as evemu-report output, which
> hopefully fills in all the details.
>
>                   Linus

Actually, it looks like this is a regression which was introduced by 
bf3e8502eefd ("Input: synaptics-rmi4 - clean up F30 implementation"). 
 From the bug report I noticed that the INPUT_PROP_BUTTONPAD property 
was not set for the touchpad. The previous behavior was to set 
INPUT_PROP_BUTTONPAD if F30 detected only one valid button (or if there 
was a flag in the platform data). But, now INPUT_PROP_BUTTONPAD is not 
being set and libinput does not know that the touchpad is a clickpad. 
After updating I was able to reproduce the issue with bf3e8502eefd applied.

Andrew