Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751657AbdCANzZ (ORCPT ); Wed, 1 Mar 2017 08:55:25 -0500 Received: from foss.arm.com ([217.140.101.70]:48690 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750787AbdCANzS (ORCPT ); Wed, 1 Mar 2017 08:55:18 -0500 Date: Wed, 1 Mar 2017 13:54:29 +0000 From: Mark Rutland To: Enric Balletbo i Serra Cc: Rob Herring , Peter Huewe , linux-kernel@vger.kernel.org, tpmdd-devel@lists.sourceforge.net, Jarkko Sakkinen , Sonny Rao Subject: Re: [PATCH] tpm: do not suspend/resume if power stays on Message-ID: <20170301135429.GF28874@leverpostej> References: <20170301115116.19696-1-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170301115116.19696-1-enric.balletbo@collabora.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1367 Lines: 38 On Wed, Mar 01, 2017 at 12:51:16PM +0100, Enric Balletbo i Serra wrote: > From: Sonny Rao > > The suspend/resume behavior of the TPM can be controlled > by setting "powered-while-suspended" in the DTS. > > Signed-off-by: Sonny Rao > Signed-off-by: Enric Balletbo i Serra > --- > Documentation/devicetree/bindings/tpm/tpm.txt | 25 +++++++++++++++++++++++++ > drivers/char/tpm/tpm_i2c_infineon.c | 25 ++++++++++++++++++++++++- > 2 files changed, 49 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/tpm/tpm.txt > > diff --git a/Documentation/devicetree/bindings/tpm/tpm.txt b/Documentation/devicetree/bindings/tpm/tpm.txt > new file mode 100644 > index 0000000..af4de0d > --- /dev/null > +++ b/Documentation/devicetree/bindings/tpm/tpm.txt > @@ -0,0 +1,25 @@ > +TPM (Trusted Platform Module) > + > +A TPM on the I2C bus is a child of the node for the bus. > + > +Required properties: > +- compatible: should be "infineon," > +- reg: the I2C address > + > +Optional properties: > +- powered-while-suspended: present when the TPM is left powered on between > + suspend and resume (makes the suspend/resume callbacks do nothing). This reads like configuration rather than a HW property. Why do you want this property? Thanks, Mark.