Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751852AbdCAOHC (ORCPT ); Wed, 1 Mar 2017 09:07:02 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:61890 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751038AbdCAOG7 (ORCPT ); Wed, 1 Mar 2017 09:06:59 -0500 Subject: Re: [PATCH 1/4] MIPS: Handle non word sized instructions when examining frame To: "Maciej W. Rozycki" References: <1488296279-23057-1-git-send-email-matt.redfearn@imgtec.com> <1488296279-23057-2-git-send-email-matt.redfearn@imgtec.com> CC: Ralf Baechle , , Marcin Nowakowski , , Paul Burton From: Matt Redfearn Message-ID: <8cf06c75-4536-3296-7413-e2dce407e8ab@imgtec.com> Date: Wed, 1 Mar 2017 13:47:53 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.150.130.83] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 830 Lines: 30 Hi Maciej On 28/02/17 20:54, Maciej W. Rozycki wrote: > On Tue, 28 Feb 2017, Matt Redfearn wrote: > >> Since the instruction modifying the stack pointer is usually the first >> in the function, that one is ususally handled correctly. But the > s/ususally/usually/ oops > >> diff --git a/arch/mips/kernel/process.c b/arch/mips/kernel/process.c >> index 803e255b6fc3..5b1e932ae973 100644 >> --- a/arch/mips/kernel/process.c >> +++ b/arch/mips/kernel/process.c >> @@ -347,6 +347,7 @@ static int get_frame_info(struct mips_frame_info *info) >> union mips_instruction insn, *ip, *ip_end; >> const unsigned int max_insns = 128; >> unsigned int i; >> + unsigned int last_insn_size = 0; > Please keep declarations in the reverse Christmas tree order, i.e. swap > the last two. > > Maciej OK, no problem. Thanks, Matt