Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751467AbdCAOXM (ORCPT <rfc822;w@1wt.eu>);
        Wed, 1 Mar 2017 09:23:12 -0500
Received: from mail-pg0-f66.google.com ([74.125.83.66]:35470 "EHLO
        mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750815AbdCAOXL (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 1 Mar 2017 09:23:11 -0500
Date: Wed, 1 Mar 2017 23:21:33 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Taeung Song <treeze.taeung@gmail.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
        Ingo Molnar <mingo@kernel.org>, Wang Nan <wangnan0@huawei.com>,
        Masami Hiramatsu <mhiramat@kernel.org>, Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view
Message-ID: <20170301142133.GC2690@danjae.aot.lge.com>
References: <1488311993-15124-1-git-send-email-treeze.taeung@gmail.com>
 <1488311993-15124-3-git-send-email-treeze.taeung@gmail.com>
 <20170301135805.GB2690@danjae.aot.lge.com>
 <20170301140833.GG6515@twins.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20170301140833.GG6515@twins.programming.kicks-ass.net>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1128
Lines: 30

Hi Peter,

On Wed, Mar 01, 2017 at 03:08:33PM +0100, Peter Zijlstra wrote:
> On Wed, Mar 01, 2017 at 10:58:05PM +0900, Namhyung Kim wrote:
> > On Wed, Mar 01, 2017 at 04:59:52AM +0900, Taeung Song wrote:
> > > The current source code view using 'objdump -S'
> > > has several limitations regarding line numbers of each soure
> > > code line and confusing mixed soure code & diassembly view.
> > > 
> > > So not use the '-S' option any more and
> > > add the new reable source code view with
> > > correct line numbers and source code per each symbol(function)
> > > using new struct source_code.
> > 
> > I like this "source-only" annotation, but some people still might want
> > to see the "mixed" annotation.  So I think you need to keep it and
> > provide another option for the source-only mode.  And then we can
> > change the default later.
> 
> What's the point of source-only? You can't even see what it is that is
> expensive.

???

This is to show source code + overhead (for each line).  People can
see which line of their source is expensive.  I think it's way more
intuitive for most developers..

Thanks,
Namhyung