Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751911AbdCAOpm (ORCPT ); Wed, 1 Mar 2017 09:45:42 -0500 Received: from merlin.infradead.org ([205.233.59.134]:41824 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751062AbdCAOpg (ORCPT ); Wed, 1 Mar 2017 09:45:36 -0500 Date: Wed, 1 Mar 2017 15:08:33 +0100 From: Peter Zijlstra To: Namhyung Kim Cc: Taeung Song , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Jiri Olsa , Ingo Molnar , Wang Nan , Masami Hiramatsu , Jiri Olsa Subject: Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Message-ID: <20170301140833.GG6515@twins.programming.kicks-ass.net> References: <1488311993-15124-1-git-send-email-treeze.taeung@gmail.com> <1488311993-15124-3-git-send-email-treeze.taeung@gmail.com> <20170301135805.GB2690@danjae.aot.lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170301135805.GB2690@danjae.aot.lge.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 825 Lines: 18 On Wed, Mar 01, 2017 at 10:58:05PM +0900, Namhyung Kim wrote: > On Wed, Mar 01, 2017 at 04:59:52AM +0900, Taeung Song wrote: > > The current source code view using 'objdump -S' > > has several limitations regarding line numbers of each soure > > code line and confusing mixed soure code & diassembly view. > > > > So not use the '-S' option any more and > > add the new reable source code view with > > correct line numbers and source code per each symbol(function) > > using new struct source_code. > > I like this "source-only" annotation, but some people still might want > to see the "mixed" annotation. So I think you need to keep it and > provide another option for the source-only mode. And then we can > change the default later. What's the point of source-only? You can't even see what it is that is expensive.