Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752389AbdCARCL (ORCPT ); Wed, 1 Mar 2017 12:02:11 -0500 Received: from mail-it0-f68.google.com ([209.85.214.68]:36627 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751291AbdCARCJ (ORCPT ); Wed, 1 Mar 2017 12:02:09 -0500 MIME-Version: 1.0 In-Reply-To: <9593504E-702C-4ABC-A72A-FAF77999B707@zytor.com> References: <863b50ccad9182c0529c63b0ae7bceb3b3fafc69.1488380822.git.jpoimboe@redhat.com> <9593504E-702C-4ABC-A72A-FAF77999B707@zytor.com> From: Linus Torvalds Date: Wed, 1 Mar 2017 09:01:54 -0800 X-Google-Sender-Auth: FB-8W0st1juvuNXDe0Gwevc-cOg Message-ID: Subject: Re: [PATCH] objtool, module: discard __unreachable section for modules To: Peter Anvin Cc: Josh Poimboeuf , Ingo Molnar , Linux Kernel Mailing List , Thomas Gleixner , Jessica Yu Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 612 Lines: 16 On Wed, Mar 1, 2017 at 8:44 AM, wrote: > > I would like to see a name like, say, ".annot.unreachable", since is odds are pretty high we are going to need more annotations in the future. Why not just make it ".discard.unreachable", and then make the discard pattern be ".discard*". We already have .discard.text for some trace hackery, so it follows a pattern. And that's what we do for things like .rodata.* etc. In fact, we already have a pattern for '.discard.*' in the main vmlinux.lds.h file exactly for the .discard.text case (but not for modules, it looks like). Linus