Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752014AbdCARFX (ORCPT ); Wed, 1 Mar 2017 12:05:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45958 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751035AbdCARFW (ORCPT ); Wed, 1 Mar 2017 12:05:22 -0500 Date: Wed, 1 Mar 2017 18:02:49 +0100 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Peter Xu Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini , Andrew Jones , Marc Zyngier , Christian Borntraeger , Cornelia Huck , James Hogan , Paul Mackerras , Christoffer Dall , David Hildenbrand Subject: Re: [PATCH v2 2/5] KVM: add KVM request variants without barrier Message-ID: <20170301170248.GD20547@potion> References: <20170224195002.28030-1-rkrcmar@redhat.com> <20170224195002.28030-3-rkrcmar@redhat.com> <20170228073424.GL10022@pxdev.xzpeter.org> <20170228074051.GM10022@pxdev.xzpeter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170228074051.GM10022@pxdev.xzpeter.org> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 01 Mar 2017 17:02:55 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 984 Lines: 25 2017-02-28 15:40+0800, Peter Xu: > On Tue, Feb 28, 2017 at 03:34:24PM +0800, Peter Xu wrote: > > [...] > >> > diff --git a/arch/mips/kvm/emulate.c b/arch/mips/kvm/emulate.c >> > index ee4af898bcf6..552ae2b5e911 100644 >> > --- a/arch/mips/kvm/emulate.c >> > +++ b/arch/mips/kvm/emulate.c >> > @@ -865,7 +865,7 @@ enum emulation_result kvm_mips_emul_wait(struct kvm_vcpu *vcpu) >> > * check if any I/O interrupts are pending. >> > */ >> > if (kvm_request_test_and_clear(KVM_REQ_UNHALT, vcpu)) { >> > - clear_bit(KVM_REQ_UNHALT, &vcpu->requests); >> > + __kvm_request_clear(KVM_REQ_UNHALT, vcpu); >> >> Shall we just remove above line since we cleared it already? > > Please ignore this since I see patch 4. :-) > > It'll be nice if patch 4 will be before this one, but it's trivial. I put [4/5] there to demonstrate that this error would have been less likely with the new naming. I didn't expect that reviewers would go through the coccinelle transformation. :)