Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752803AbdCAR6B (ORCPT ); Wed, 1 Mar 2017 12:58:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50162 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751099AbdCAR56 (ORCPT ); Wed, 1 Mar 2017 12:57:58 -0500 Date: Wed, 1 Mar 2017 18:04:04 +0100 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: James Hogan Cc: David Hildenbrand , Andrew Jones , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini , Marc Zyngier , Christian Borntraeger , Cornelia Huck , Paul Mackerras , Christoffer Dall Subject: Re: [PATCH v2 4/5] KVM: MIPS: remove useless kvm_request_clear Message-ID: <20170301170403.GE20547@potion> References: <20170224195002.28030-1-rkrcmar@redhat.com> <20170224195002.28030-5-rkrcmar@redhat.com> <20170227084539.oq3uviixwsjtmpdj@kamzik.brq.redhat.com> <20170228112903.GK996@jhogan-linux.le.imgtec.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170228112903.GK996@jhogan-linux.le.imgtec.org> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 01 Mar 2017 17:04:09 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1164 Lines: 35 2017-02-28 11:29+0000, James Hogan: > On Mon, Feb 27, 2017 at 11:03:51AM +0100, David Hildenbrand wrote: >> Am 27.02.2017 um 09:45 schrieb Andrew Jones: >> > On Fri, Feb 24, 2017 at 08:50:01PM +0100, Radim Krčmář wrote: >> >> Signed-off-by: Radim Krčmář >> >> --- >> >> arch/mips/kvm/emulate.c | 1 - >> >> 1 file changed, 1 deletion(-) >> >> >> >> diff --git a/arch/mips/kvm/emulate.c b/arch/mips/kvm/emulate.c >> >> index 552ae2b5e911..70614ca41744 100644 >> >> --- a/arch/mips/kvm/emulate.c >> >> +++ b/arch/mips/kvm/emulate.c >> >> @@ -865,7 +865,6 @@ enum emulation_result kvm_mips_emul_wait(struct kvm_vcpu *vcpu) >> >> * check if any I/O interrupts are pending. >> >> */ >> >> if (kvm_request_test_and_clear(KVM_REQ_UNHALT, vcpu)) { >> >> - __kvm_request_clear(KVM_REQ_UNHALT, vcpu); >> >> vcpu->run->exit_reason = KVM_EXIT_IRQ_WINDOW_OPEN; >> >> } >> > >> > should remove the {} too. >> > >> >> With that, >> >> Reviewed-by: David Hildenbrand > > and with that: > > Acked-by: James Hogan I'll do that when applying or posting v3, thanks for catching that.