Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753306AbdCAS6d (ORCPT ); Wed, 1 Mar 2017 13:58:33 -0500 Received: from mail-it0-f53.google.com ([209.85.214.53]:37384 "EHLO mail-it0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753270AbdCAS63 (ORCPT ); Wed, 1 Mar 2017 13:58:29 -0500 MIME-Version: 1.0 In-Reply-To: <20170301090347.GE7064@mail.corp.redhat.com> References: <20170301032409.GA8206@jelly> <20170301090347.GE7064@mail.corp.redhat.com> From: Linus Torvalds Date: Wed, 1 Mar 2017 09:54:07 -0800 X-Google-Sender-Auth: 18OKa73zKKPgw8PES4kqUPiblQk Message-ID: Subject: Re: [GIT PULL] HID for 4.11 To: Benjamin Tissoires , Dmitry Torokhov Cc: Peter Hutterer , Andrew Duggan , Jiri Kosina , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1119 Lines: 30 On Wed, Mar 1, 2017 at 1:03 AM, Benjamin Tissoires wrote: > > As Peter mentioned in the bug, there is a missing property on the kernel > node (INPUT_PROP_BUTTONPAD). > > The thing is this property is solely driven in the current driver by the > provided platform_data, so there is no way we ever set it through > hid-rmi. I wonder how we missed that. > > Anyway, the good news is that the evemu record shows only one exportted > button, so we can infer the property quite easily in the module. Would > something like that work for you? > > From: Benjamin Tissoires > Date: Wed, 1 Mar 2017 09:57:00 +0100 > Subject: [PATCH] Input: rmi4 - f30: detect INPUT_PROP_BUTTONPAD from the button count Yes, this fixes the problem for me. My click-and-drag works again, so you can add a Reported-and-tested-by: Linus Torvalds I see that Dmitry doesn't love the patch, but I'm assuming I'll get that or something equivalent soon. In the meantime, I'll just keep it on my laptop as a workaround. Thanks, Linus