Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751821AbdCATrg (ORCPT ); Wed, 1 Mar 2017 14:47:36 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:48916 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751595AbdCATrd (ORCPT ); Wed, 1 Mar 2017 14:47:33 -0500 Date: Wed, 1 Mar 2017 11:37:50 +0000 From: Mark Brown To: Jeremy Linton Cc: puck.chen@hisilicon.com, lgirdwood@gmail.com, linux-kernel@vger.kernel.org Message-ID: <20170301113750.airgtqq5jivmjuod@sirena.org.uk> References: <20170301010706.31899-1-lintonrjeremy@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6lz5izoc3q4podvw" Content-Disposition: inline In-Reply-To: <20170301010706.31899-1-lintonrjeremy@gmail.com> X-Cookie: Take your Senator to lunch this week. User-Agent: NeoMutt/20161126 (1.7.1) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regulator: hi655x: Add DT bindings so module autoloads X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1524 Lines: 40 --6lz5izoc3q4podvw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 28, 2017 at 07:07:06PM -0600, Jeremy Linton wrote: > The hi655x driver is required for mmc/sd functionality on the > 96boards hikey, and likely other platforms. When built as > a standalone module it doesn't get automatically loaded because > it is missing the module probe hooks. > +static const struct of_device_id hi655x_dt_ids[] = { > + { .compatible = "hisilicon,hi655x-pmic", }, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, hi655x_dt_ids); This is an MFD subdevice, I'd expect it to instantiate as a platform device from the MFD - there shouldn't be a compatible string in the DT and indeed one is not documented (I see something slipped into the example but it's not in the actual binding). It's not like this device can exist independently of the parent device and that compatible string is not specific enough anyway. --6lz5izoc3q4podvw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAli2so0ACgkQJNaLcl1U h9AxpAf+POARU/xyqNSJv0NTqFBVe47YI8t4Hut87bD2EAP81SHr+W8/sAIzFPsH tXB7MXrLTBz7z9cCRSaGM7TEYAwr3gX6faupEPNOWRN13rnADWy9X2jn2kpevL92 zIbZN9bkFV5K8x20PVkhmKAah7t9U92YV6/PE9K1n4lXb8E8v1ggHY94Ug4W5l/X 6hyH1LyAVshrQMwtk0Ph458cDyP8nn8c2jGwny3Vj5JwOWlmlm27WUDpxYXFhy80 xKoEdp1HXnWeHbh3izilKV58INOsS7lDMa/4lmSRuDUiDmlKOH539IrBu/R3On4s gnqaI8LrJ7PEnjyikA5kuwahyb42Bg== =eyC7 -----END PGP SIGNATURE----- --6lz5izoc3q4podvw--