Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752320AbdCATsJ (ORCPT ); Wed, 1 Mar 2017 14:48:09 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:48900 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750734AbdCATra (ORCPT ); Wed, 1 Mar 2017 14:47:30 -0500 Date: Wed, 1 Mar 2017 17:40:04 +0000 From: Mark Brown To: Jeremy Linton Cc: puck.chen@hisilicon.com, lgirdwood@gmail.com, linux-kernel@vger.kernel.org Message-ID: <20170301174004.rakmjjpsq42nbbay@sirena.org.uk> References: <20170301010706.31899-1-lintonrjeremy@gmail.com> <20170301113750.airgtqq5jivmjuod@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="idxnsvg2ebxxi54x" Content-Disposition: inline In-Reply-To: X-Cookie: Take your Senator to lunch this week. User-Agent: NeoMutt/20161126 (1.7.1) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regulator: hi655x: Add DT bindings so module autoloads X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1715 Lines: 47 --idxnsvg2ebxxi54x Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 01, 2017 at 10:44:16AM -0600, Jeremy Linton wrote: > Right, there also appears to be dependency issues. Its like the > regulator should be pulling in the parent pmic rather than the current No, why would it do that? The regulator can't be instantiated without the parent so it can't do anything until the parent appears. > situation where the pmic loads, the mmc subsystem loads, but then > triggers hung task timeouts until the regulator is manually loaded. If MMC needs a regulator it should be deferring probe until the regulator appears. > Worse, because the pmic isn't being held by the regulator you get this > if the pmic is unloaded. >=20 > [31695.158053] ------------[ cut here ]------------ > [31695.162713] WARNING: CPU: 4 PID: 1729 at > drivers/regulator/core.c:4136 regulator_unregister+0xfc/0x104 This is nothing to do with the parent, this is telling you that you're removing a device which is currently in use which is obviously not going to go well. --idxnsvg2ebxxi54x Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAli3B3QACgkQJNaLcl1U h9B40Qf/ZBdwmN7p4LTznlfN/Ux3IoPOgErtz+mj22ixdpbykLXAXUAP4nRp1oiG vmfqUg3i5EW3W3NsC3OmEJ+HzK4vHTl82HVnxXvLZM+TG0er6z4aJIp2WVaCbZY1 yLgLpinfx4GGBV6JLpy0JNS0THqytmMYJlk453hbdiOGIjeBvfojdHh4VxnWfyCD rydbtE+XTppstkypZynUVwCe8ypL+/JEgGE6ygN4PZRKtIgW0Dh8tIvSoTD6LvsU 4Pbhpu4CqwLc7SXka5m1xyFyUyr/KxaCHNOTI2mSAH870aCPUR2XcnB3XOdaWoxv 49GZD/BXDz84w/TSAh9eW845c2q36Q== =WINy -----END PGP SIGNATURE----- --idxnsvg2ebxxi54x--