Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751426AbdCATv3 convert rfc822-to-8bit (ORCPT ); Wed, 1 Mar 2017 14:51:29 -0500 Received: from plaes.org ([188.166.43.21]:49634 "EHLO plaes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750705AbdCATv1 (ORCPT ); Wed, 1 Mar 2017 14:51:27 -0500 Message-ID: <1488397315.29650.1.camel@plaes.org> Subject: Re: [linux-sunxi] [PATCH 3/4] ARM: sun7i: Convert to CCU From: Priit Laes To: emilio@elopez.com.ar Cc: Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai , Russell King , Icenowy Zheng , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Date: Wed, 01 Mar 2017 21:41:55 +0200 In-Reply-To: References: <20170227210914.18954-1-plaes@plaes.org> <20170227210914.18954-4-plaes@plaes.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Evolution 3.22.5 (3.22.5-1.fc25) Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2470 Lines: 72 On Tue, 2017-02-28 at 14:01 -0300, Emilio López wrote: > Hi, > > I spotted a couple of things here on a quick look, see below > > El 27/02/17 a las 18:09, Priit Laes escribió: > > Convert sun7i-a20.dtsi to new CCU driver. > > > > > > Signed-off-by: Priit Laes > > --- > >  arch/arm/boot/dts/sun7i-a20.dtsi | 719 +++++---------------------------------- > >  1 file changed, 86 insertions(+), 633 deletions(-) > > > > diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi > > index 04c9977..6f80cb8 100644 > > --- a/arch/arm/boot/dts/sun7i-a20.dtsi > > +++ b/arch/arm/boot/dts/sun7i-a20.dtsi > > @@ -47,7 +47,8 @@ > >  #include > >  #include > >   > > -#include > > +#include > > +#include > >  #include > >  #include > >   > > @@ -67,19 +68,19 @@ > > > >   compatible = "allwinner,simple-framebuffer", > > > >        "simple-framebuffer"; > > > >   allwinner,pipeline = "de_be0-lcd0-hdmi"; > > > > - clocks = <&ahb_gates 36>, <&ahb_gates 43>, > > > > -  <&ahb_gates 44>, <&de_be0_clk>, > > > > -  <&tcon0_ch1_clk>, <&dram_gates 26>; > > > > + clocks = <&ccu CLK_AHB_LCD0>, <&ccu CLK_AHB_HDMI1>, > > > > +  <&ccu CLK_AHB_DE_BE0>, <&ccu CLK_DE_BE0>, > > > > +  <&ccu CLK_TCON0_CH1>, <&ccu CLK_DRAM_DE_BE0>; > > > >   status = "disabled"; > > > >   }; > >   > > > > - framebuffer@1 { > > + framebuffer@0 { > > This looks like an unrelated change Yup, that 's leftover from changes made during initial debugging. Will fix in v2. > > > @@ -184,21 +185,11 @@ > >   > > > > > >   osc24M: clk@01c20050 { > > > >   #clock-cells = <0>; > > > > - compatible = "allwinner,sun4i-a10-osc-clk"; > > > > - reg = <0x01c20050 0x4>; > > > > + compatible = "fixed-clock"; > > > >   clock-frequency = <24000000>; > > > >   clock-output-names = "osc24M"; > >   }; > > allwinner,sun4i-a10-osc-clk implements a gate apart from a fixed clock, > is the feature loss intended? This is how most of the existing drivers handle it (A13, A31, A33) so I didn't want to do anything fancy.. Besides, the code for clock actually configures gate: static SUNXI_CCU_GATE(hosc_clk, "hosc", "osc24M", 0x050, BIT(0), 0); Päikest, Priit