Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754117AbdCBCQn (ORCPT ); Wed, 1 Mar 2017 21:16:43 -0500 Received: from mail-qk0-f177.google.com ([209.85.220.177]:36047 "EHLO mail-qk0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754025AbdCBCQl (ORCPT ); Wed, 1 Mar 2017 21:16:41 -0500 MIME-Version: 1.0 In-Reply-To: <20170224103309.19463-1-kernel@kempniu.pl> References: <20170224103309.19463-1-kernel@kempniu.pl> From: Andy Shevchenko Date: Thu, 2 Mar 2017 01:03:14 +0200 Message-ID: Subject: Re: [PATCH 0/4] Improve intel-hid's self-consistency To: =?UTF-8?B?TWljaGHFgiBLxJlwaWXFhA==?= Cc: Alex Hung , Darren Hart , Andy Shevchenko , Platform Driver , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v222Gomd011043 Content-Length: 653 Lines: 16 On Fri, Feb 24, 2017 at 12:33 PM, Michał Kępień wrote: > Commit 2cfa4b311acc ("platform/x86: intel-hid: Support 5 button array") > contains some coding style cleanups compared to the code it was based > on. This patch series "backports" these cleanups to the rest of the > driver in order to make it more self-consistent and removes a redundant > set_bit() call as a bonus. > > This series was not tested on hardware supported by intel-hid. Alex, do you have an access to hardware to test? I wouldn't going to apply this until I get your tag(s) (in the best case Reviewed-and-tested-by). -- With Best Regards, Andy Shevchenko