Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752343AbdCBKtv (ORCPT ); Thu, 2 Mar 2017 05:49:51 -0500 Received: from mail-pg0-f41.google.com ([74.125.83.41]:33718 "EHLO mail-pg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752268AbdCBKtr (ORCPT ); Thu, 2 Mar 2017 05:49:47 -0500 Date: Thu, 2 Mar 2017 16:09:57 +0530 From: Viresh Kumar To: Daniel Kurtz Cc: Yidi Lin , Nicolas Boichat , "Rafael J. Wysocki" , Matthias Brugger , "open list:CPU FREQUENCY DRIVERS" , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" Subject: Re: [PATCH] cpufreq: mt8173: Add support for MT8176 and MT817x compatibles Message-ID: <20170302103957.GB13760@vireshk-i7> References: <20170302103626.69195-1-djkurtz@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170302103626.69195-1-djkurtz@chromium.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2023 Lines: 70 On 02-03-17, 18:36, Daniel Kurtz wrote: > The Mediatek MT8173 is just on of several SOCs from the same MT817x family, s/on/one > including the 6-core (4-little/2-big) MT8176. > > The mt8173-cpufreq driver supports all of these SOCs, however, machines > using them may use a different machine compatible. > > Since this driver checks explicitly for the machine compatible string, add > support for the whole family. > > Signed-off-by: Daniel Kurtz > --- > This patch is based on the compatibles added by the MT8176 series: > > https://patchwork.kernel.org/patch/9573209/ > https://patchwork.kernel.org/patch/9573213/ > > drivers/cpufreq/mt8173-cpufreq.c | 25 +++++++++++++++++++++++-- > 1 file changed, 23 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/mt8173-cpufreq.c b/drivers/cpufreq/mt8173-cpufreq.c > index ab25b1235a5e..07f7aac56f31 100644 > --- a/drivers/cpufreq/mt8173-cpufreq.c > +++ b/drivers/cpufreq/mt8173-cpufreq.c > @@ -573,13 +573,34 @@ static struct platform_driver mt8173_cpufreq_platdrv = { > .probe = mt8173_cpufreq_probe, > }; > > +/* List of machine compatible strings supported by this driver */ > +static const char *mt8173_cpufreq_machines[] = { > + "mediatek,mt817x", > + "mediatek,mt8173", > + "mediatek,mt8176", > +}; > + > +static int mt8173_cpufreq_is_compatible(void) > +{ > + int i; > + > + for (i = 0; i < ARRAY_SIZE(mt8173_cpufreq_machines); i++) > + if (of_machine_is_compatible(mt8173_cpufreq_machines[i])) > + return 0; > + > + return -ENODEV; > +} > + > static int mt8173_cpufreq_driver_init(void) > { > struct platform_device *pdev; > int err; > > - if (!of_machine_is_compatible("mediatek,mt8173")) > - return -ENODEV; > + err = mt8173_cpufreq_is_compatible(); Use of_match_node() instead (hint: cpufreq-dt-platdev.c) > + if (err) { > + pr_err("Machine is not compatible with 'mediatek,mt8173'\n"); > + return err; > + } > > err = platform_driver_register(&mt8173_cpufreq_platdrv); > if (err) -- viresh