From: Dexuan Cui <decui@microsoft.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>,
        "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "KY Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        "Alex Ng (LIS)" <alexng@microsoft.com>
Subject: RE: [PATCH] Drivers: hv: util: move waiting for release to
 hv_utils_transport itself
Thread-Topic: [PATCH] Drivers: hv: util: move waiting for release to
 hv_utils_transport itself
Thread-Index: AQHSkzoQa95pMltxr0uV/qQExn424KGBUkyA
Date: Thu, 2 Mar 2017 10:06:13 +0000
Message-ID: <MWHPR03MB266975E97D6A4644E1E49026BF280@MWHPR03MB2669.namprd03.prod.outlook.com>
References: <20170302094749.3097-1-vkuznets@redhat.com>
In-Reply-To: <20170302094749.3097-1-vkuznets@redhat.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2017 10:06:13.6852
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2734
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v22CgsHB020789
Content-Length: 1276
Lines: 27

> From: Vitaly Kuznetsov [mailto:vkuznets@redhat.com]
> Sent: Thursday, March 2, 2017 17:48
> To: devel@linuxdriverproject.org
> Cc: linux-kernel@vger.kernel.org; KY Srinivasan <kys@microsoft.com>; Haiyang
> Zhang <haiyangz@microsoft.com>; Stephen Hemminger
> <sthemmin@microsoft.com>; Dexuan Cui <decui@microsoft.com>; Alex Ng (LIS)
> <alexng@microsoft.com>
> Subject: [PATCH] Drivers: hv: util: move waiting for release to hv_utils_transport
> itself
> 
> Waiting for release_event in all three drivers introduced issues on release
> as on_reset() hook is not always called. E.g. if the device was never
> opened we will never get the completion.
> 
> Move the waiting code to hvutil_transport_destroy() and make sure it is
> only called when the device is open. hvt->lock serialization should
> guarantee the absence of races.
> 
> Fixes: 5a66fecbf6aa ("Drivers: hv: util: kvp: Fix a rescind processing issue")
> Fixes: 20951c7535b5 ("Drivers: hv: util: Fcopy: Fix a rescind processing issue")
> Fixes: d77044d142e9 ("Drivers: hv: util: Backup: Fix a rescind processing issue")
> Reported-by: Dexuan Cui <decui@microsoft.com>
> Tested-by: Dexuan Cui <decui@microsoft.com>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>

Acked-by: Dexuan Cui <decui@microsoft.com>