Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752955AbdCBNvu (ORCPT ); Thu, 2 Mar 2017 08:51:50 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:36021 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752687AbdCBNtL (ORCPT ); Thu, 2 Mar 2017 08:49:11 -0500 From: Andrey Konovalov To: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Andrey Konovalov Subject: [PATCH v2 7/9] kasan: print page description after stacks Date: Thu, 2 Mar 2017 14:48:49 +0100 Message-Id: <20170302134851.101218-8-andreyknvl@google.com> X-Mailer: git-send-email 2.12.0.rc1.440.g5b76565f74-goog In-Reply-To: <20170302134851.101218-1-andreyknvl@google.com> References: <20170302134851.101218-1-andreyknvl@google.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1236 Lines: 41 Moves page description after the stacks since it's less important. Signed-off-by: Andrey Konovalov --- mm/kasan/report.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/mm/kasan/report.c b/mm/kasan/report.c index 8dfb7a060d69..1d2b15174a98 100644 --- a/mm/kasan/report.c +++ b/mm/kasan/report.c @@ -259,9 +259,6 @@ static void print_address_description(struct kasan_access_info *info) void *addr = (void *)info->access_addr; struct page *page = addr_to_page(addr); - if (page) - dump_page(page, "kasan: bad access detected"); - dump_stack(); if (page && PageSlab(page)) { @@ -271,9 +268,14 @@ static void print_address_description(struct kasan_access_info *info) describe_object(cache, object, addr); } - if (kernel_or_module_addr(addr)) { - if (!init_task_stack_addr(addr)) - pr_err("Address belongs to variable %pS\n", addr); + if (kernel_or_module_addr(addr) && !init_task_stack_addr(addr)) { + pr_err("The buggy address belongs to the variable:\n"); + pr_err(" %pS\n", addr); + } + + if (page) { + pr_err("The buggy address belongs to the page:\n"); + dump_page(page, "kasan: bad access detected"); } } -- 2.12.0.rc1.440.g5b76565f74-goog