Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753477AbdCBOOD (ORCPT ); Thu, 2 Mar 2017 09:14:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48742 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752736AbdCBONx (ORCPT ); Thu, 2 Mar 2017 09:13:53 -0500 Date: Thu, 2 Mar 2017 15:10:53 +0100 From: Benjamin Tissoires To: Jaejoong Kim Cc: jikos@kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 1/2] HID: hiddev: move hiddev's minor number from struct hid_device to hiddev Message-ID: <20170302141053.GN7064@mail.corp.redhat.com> References: <1488462330-12349-1-git-send-email-climbbb.kim@gmail.com> <1488462330-12349-2-git-send-email-climbbb.kim@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1488462330-12349-2-git-send-email-climbbb.kim@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 02 Mar 2017 14:10:59 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1640 Lines: 51 On Mar 02 2017 or thereabouts, Jaejoong Kim wrote: > We need to store the minor number each drivers. In case of hidraw, it's > minor number stores in struct hidraw. But hiddev's minor is located in > struct hid_device. > > So reallocates for hiddev's minor number. > There is not a real need to have this one in a separate patch. Also, it depends on the patch "[PATCH] HID: cp2112: use proper hidraw name with minor number", so better include this cp2112 in this series (as I mentioned in the cp2112 patch). I'd say simply squash this patch with 2/2 and have the cp2112 as 1/2. Cheers, Benjamin > Signed-off-by: Jaejoong Kim > --- > drivers/hid/usbhid/hiddev.c | 1 + > include/linux/hid.h | 1 - > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c > index 700145b..5c2c489 100644 > --- a/drivers/hid/usbhid/hiddev.c > +++ b/drivers/hid/usbhid/hiddev.c > @@ -47,6 +47,7 @@ > #define HIDDEV_BUFFER_SIZE 2048 > > struct hiddev { > + int minor; > int exist; > int open; > struct mutex existancelock; > diff --git a/include/linux/hid.h b/include/linux/hid.h > index 28f38e2b8..643c017 100644 > --- a/include/linux/hid.h > +++ b/include/linux/hid.h > @@ -541,7 +541,6 @@ struct hid_device { /* device report descriptor */ > struct list_head inputs; /* The list of inputs */ > void *hiddev; /* The hiddev structure */ > void *hidraw; > - int minor; /* Hiddev minor number */ > > int open; /* is the device open by anyone? */ > char name[128]; /* Device name */ > -- > 2.7.4 >