Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754214AbdCBO50 (ORCPT ); Thu, 2 Mar 2017 09:57:26 -0500 Received: from mail.kernel.org ([198.145.29.136]:54004 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753878AbdCBO4x (ORCPT ); Thu, 2 Mar 2017 09:56:53 -0500 Date: Thu, 2 Mar 2017 09:49:27 -0500 From: Steven Rostedt To: Aleksey Makarov Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Sudeep Holla , Greg Kroah-Hartman , Peter Hurley , Jiri Slaby , Robin Murphy , "Nair, Jayachandran" , Petr Mladek , Sergey Senozhatsky Subject: Re: [PATCH v2 1/3] printk: fix name/type/scope of preferred_console var Message-ID: <20170302094927.72989efe@gandalf.local.home> In-Reply-To: <20170302131153.22733-2-aleksey.makarov@linaro.org> References: <20170302131153.22733-1-aleksey.makarov@linaro.org> <20170302131153.22733-2-aleksey.makarov@linaro.org> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 491 Lines: 18 On Thu, 2 Mar 2017 16:11:32 +0300 Aleksey Makarov wrote: > The variable preferred_console is used only inside register_console() > and its semantics is boolean. It is negative when no console has been > made preferred. > > Make it static bool and rename to has_preferred. > > Renaming was suggested by Peter Hurley > Reviewed-by: Steven Rostedt (VMware) -- Steve > Signed-off-by: Aleksey Makarov > ---