Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751557AbdCBPFf (ORCPT ); Thu, 2 Mar 2017 10:05:35 -0500 Received: from mail.kernel.org ([198.145.29.136]:55136 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753511AbdCBPEo (ORCPT ); Thu, 2 Mar 2017 10:04:44 -0500 Date: Thu, 2 Mar 2017 10:01:53 -0500 From: Steven Rostedt To: Aleksey Makarov Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Sudeep Holla , Greg Kroah-Hartman , Peter Hurley , Jiri Slaby , Robin Murphy , "Nair, Jayachandran" , Petr Mladek , Sergey Senozhatsky Subject: Re: [PATCH v2 2/3] printk: rename selected_console -> preferred_console Message-ID: <20170302100153.410acdc9@gandalf.local.home> In-Reply-To: <20170302131153.22733-3-aleksey.makarov@linaro.org> References: <20170302131153.22733-1-aleksey.makarov@linaro.org> <20170302131153.22733-3-aleksey.makarov@linaro.org> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 718 Lines: 21 On Thu, 2 Mar 2017 16:11:33 +0300 Aleksey Makarov wrote: > The variable selected_console is set in __add_preferred_console() > to point to the last console parameter that was added to the > console_cmdline array. > > Rename it to preferred_console so that the name reflects the usage. As I said previously, I prefer "selected_console" but since "__add_preferred_console()" sets it, I'm fine with this change. Although, I would probably have changed that function to "__add_selected_console()" :) Acked-by: Steven Rostedt (VMware) -- Steve > > Suggested-by: Peter Hurley > Signed-off-by: Aleksey Makarov