Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754363AbdCBQz1 (ORCPT ); Thu, 2 Mar 2017 11:55:27 -0500 Received: from mail-pf0-f181.google.com ([209.85.192.181]:34405 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753329AbdCBQzX (ORCPT ); Thu, 2 Mar 2017 11:55:23 -0500 Date: Thu, 2 Mar 2017 08:53:21 -0800 From: Stephen Hemminger To: Vitaly Kuznetsov Cc: devel@linuxdriverproject.org, Stephen Hemminger , Alex Ng , Haiyang Zhang , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Drivers: hv: util: move waiting for release to hv_utils_transport itself Message-ID: <20170302085321.6dcf4a36@xeon-e3> In-Reply-To: <20170302094749.3097-1-vkuznets@redhat.com> References: <20170302094749.3097-1-vkuznets@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 911 Lines: 19 On Thu, 2 Mar 2017 10:47:49 +0100 Vitaly Kuznetsov wrote: > Waiting for release_event in all three drivers introduced issues on release > as on_reset() hook is not always called. E.g. if the device was never > opened we will never get the completion. > > Move the waiting code to hvutil_transport_destroy() and make sure it is > only called when the device is open. hvt->lock serialization should > guarantee the absence of races. > > Fixes: 5a66fecbf6aa ("Drivers: hv: util: kvp: Fix a rescind processing issue") > Fixes: 20951c7535b5 ("Drivers: hv: util: Fcopy: Fix a rescind processing issue") > Fixes: d77044d142e9 ("Drivers: hv: util: Backup: Fix a rescind processing issue") > Reported-by: Dexuan Cui > Tested-by: Dexuan Cui > Signed-off-by: Vitaly Kuznetsov Acked-by: Stephen Hemminger