Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752251AbdCBUrC (ORCPT ); Thu, 2 Mar 2017 15:47:02 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:50916 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751460AbdCBUqf (ORCPT ); Thu, 2 Mar 2017 15:46:35 -0500 Date: Thu, 2 Mar 2017 21:22:20 +0100 From: Boris Brezillon To: Alban Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mtd@lists.infradead.org, Cyrille Pitchen , Richard Weinberger , Marek Vasut , Brian Norris , David Woodhouse , Mark Rutland , Rob Herring , Maxime Ripard , Srinivas Kandagatla , Moritz Fischer Subject: Re: [PATCH 1/3] doc: bindings: Add bindings documentation for mtd nvmem Message-ID: <20170302212220.4c3c7bef@bbrezillon> In-Reply-To: <1488484223-844-2-git-send-email-albeu@free.fr> References: <1488484223-844-1-git-send-email-albeu@free.fr> <1488484223-844-2-git-send-email-albeu@free.fr> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1584 Lines: 52 On Thu, 2 Mar 2017 20:50:21 +0100 Alban wrote: > Add the binding to expose MTD partitions as nvmem providers. Looks good. Maybe you should take the case you describe in your cover-letter into account and add an extra layer: add an nvmem sub-node containing the nvmem cells, so that you can expose nvmem cells directly under master MTD devices (and not only partitions). > > Signed-off-by: Alban > --- > .../devicetree/bindings/nvmem/mtd-nvmem.txt | 29 ++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > create mode 100644 Documentation/devicetree/bindings/nvmem/mtd-nvmem.txt > > diff --git a/Documentation/devicetree/bindings/nvmem/mtd-nvmem.txt b/Documentation/devicetree/bindings/nvmem/mtd-nvmem.txt > new file mode 100644 > index 0000000..47602f7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/nvmem/mtd-nvmem.txt > @@ -0,0 +1,29 @@ > += NVMEM in MTD = > + > +Config data for drivers is often stored in MTD devices. This binding > +define how such data can be represented in device tree. > + > +An MTD can be defined as an NVMEM provider by adding the `nvmem-provider` > +property to their node. Data cells can then be defined as child nodes > +of the partition as defined in nvmem.txt. > + > +Example: > + > + flash@0 { > + ... > + > + partition@2 { > + label = "art"; > + reg = <0x7F0000 0x010000>; > + read-only; > + > + nvmem-provider; > + #address-cells = <1>; > + #size-cells = <1>; > + > + eeprom@1000 { > + label = "wmac-eeprom"; > + reg = <0x1000 0x1000>; > + }; > + }; > + };