Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751260AbdCBVLZ (ORCPT ); Thu, 2 Mar 2017 16:11:25 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:57774 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750779AbdCBVLX (ORCPT ); Thu, 2 Mar 2017 16:11:23 -0500 Subject: Re: [RFC 03/11] mm: remove SWAP_DIRTY in ttu To: Minchan Kim , Andrew Morton References: <1488436765-32350-1-git-send-email-minchan@kernel.org> <1488436765-32350-4-git-send-email-minchan@kernel.org> Cc: kernel-team@lge.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Michal Hocko , Shaohua Li From: Anshuman Khandual Date: Thu, 2 Mar 2017 20:12:59 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1488436765-32350-4-git-send-email-minchan@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17030214-0016-0000-0000-000003ECA80E X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17030214-0017-0000-0000-000028D2D5D8 Message-Id: <339d97b2-aeda-29ff-514c-d883e87c7a14@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-02_13:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1703020134 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 494 Lines: 9 On 03/02/2017 12:09 PM, Minchan Kim wrote: > If we found lazyfree page is dirty, ttuo can just SetPageSwapBakced > in there like PG_mlocked page and just return with SWAP_FAIL which > is very natural because the page is not swappable right now so that > vmscan can activate it. There is no point to introduce new return > value SWAP_DIRTY in ttu at the moment. Yeah makes sense. In the process, SetPageSwapBacked marking of the page is moved from the shrink_page_list() to try_to_unmap_one().