Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751737AbdCBVT0 (ORCPT ); Thu, 2 Mar 2017 16:19:26 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:38548 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751009AbdCBVTU (ORCPT ); Thu, 2 Mar 2017 16:19:20 -0500 Date: Thu, 02 Mar 2017 12:56:05 -0800 (PST) Message-Id: <20170302.125605.1084925031741881031.davem@davemloft.net> To: jon.mason@broadcom.com Cc: rafal@milecki.pl, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v4 0/2] net: ethernet: bgmac: bug fixes From: David Miller In-Reply-To: <20170302.125015.275943458708603387.davem@davemloft.net> References: <1488307311-11933-1-git-send-email-jon.mason@broadcom.com> <20170302.125015.275943458708603387.davem@davemloft.net> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 02 Mar 2017 12:56:06 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v22LJde3019803 Content-Length: 1411 Lines: 35 From: David Miller Date: Thu, 02 Mar 2017 12:50:15 -0800 (PST) > From: Jon Mason > Date: Tue, 28 Feb 2017 13:41:49 -0500 > >> Changes in v4: >> * Added the udelays from the previous code (per David Miller) >> >> Changes in v3: >> * Reworked the init sequence patch to only remove the device reset if >> the device is actually in reset. Given that this code doesn't bear >> much resemblance to the original code, I'm changing the author of the >> patch. This was tested on NS2 SVK. >> >> Changes in v2: >> * Reworked the first match to make it more obvious what portions of the >> register were being preserved (Per Rafal Mileki) >> * Style change to reorder the function variables in patch 2 (per Sergei >> Shtylyov) >> >> Bug fixes for bgmac driver > > Series applied. Actually, this doesn't even compile. Reverted... [davem@kkuri net]$ make -s -j4 drivers/net/ethernet/broadcom/bgmac.c: In function ?bgmac_set_mac_address?: drivers/net/ethernet/broadcom/bgmac.c:1233:23: error: ?struct bgmac? has no member named ?mac_addr?; did you mean ?phyaddr?? ether_addr_copy(bgmac->mac_addr, sa->sa_data); ^~ drivers/net/ethernet/broadcom/bgmac.c:1234:38: error: ?struct bgmac? has no member named ?mac_addr?; did you mean ?phyaddr?? bgmac_write_mac_address(bgmac, bgmac->mac_addr); ^~