Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751492AbdCBWvv (ORCPT ); Thu, 2 Mar 2017 17:51:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58972 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751150AbdCBWvt (ORCPT ); Thu, 2 Mar 2017 17:51:49 -0500 Date: Thu, 2 Mar 2017 17:49:57 -0500 From: Jessica Yu To: David Daney Cc: Steven Rostedt , Rusty Russell , David Daney , Jason Baron , Michael Ellerman , Sachin Sant , linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Chris Metcalf , Ralf Baechle , Russell King , Rabin Vincent , Paul Mackerras , Anton Blanchard , Ingo Molnar , Zhigang Lu Subject: Re: [PATCH] module: set __jump_table alignment to 8 Message-ID: <20170302224957.GC13268@packer-debian-8-amd64.digitalocean.com> References: <20170301220453.4756-1-david.daney@cavium.com> <20170302131119.6f52203f@gandalf.local.home> <20170302182625.GB13268@packer-debian-8-amd64.digitalocean.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-OS: Linux eisen.io 3.16.0-4-amd64 x86_64 User-Agent: Mutt/1.5.23 (2014-03-12) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 02 Mar 2017 22:49:59 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1704 Lines: 56 +++ David Daney [02/03/17 11:24 -0800]: >On 03/02/2017 10:26 AM, Jessica Yu wrote: >>+++ Steven Rostedt [02/03/17 13:11 -0500]: >>> >>>Can I get an Ack from a module maintainer? >> >>Acked-by: Jessica Yu >> >>Thanks! >> >>Jessica > >Thanks Jessica, > >Can you also add scripts/module-common.lds to MAINTAINERS so that >get_maintainers.pl will indicate that Jessica Yu and Rusty Russell be >CCed on things like this in the future? Sure thing. Thanks for the heads up! Jessica >>>On Wed, 1 Mar 2017 14:04:53 -0800 >>>David Daney wrote: >>> >>>>For powerpc the __jump_table section in modules is not aligned, this >>>>causes a WARN_ON() splat when loading a module containing a >>>>__jump_table. >>>> >>>>Strict alignment became necessary with commit 3821fd35b58d >>>>("jump_label: Reduce the size of struct static_key"), currently in >>>>linux-next, which uses the two least significant bits of pointers to >>>>__jump_table elements. >>>> >>>>Fix by forcing __jump_table to 8, which is the same alignment used for >>>>this section in the kernel proper. >>>> >>>>Signed-off-by: David Daney >>>>Tested-by: Sachin Sant >>>>--- >>>> scripts/module-common.lds | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>>diff --git a/scripts/module-common.lds b/scripts/module-common.lds >>>>index 73a2c7d..53234e8 100644 >>>>--- a/scripts/module-common.lds >>>>+++ b/scripts/module-common.lds >>>>@@ -19,4 +19,6 @@ SECTIONS { >>>> >>>> . = ALIGN(8); >>>> .init_array 0 : { *(SORT(.init_array.*)) *(.init_array) } >>>>+ >>>>+ __jump_table 0 : ALIGN(8) { KEEP(*(__jump_table)) } >>>> } >>> >