Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751660AbdCCC4u (ORCPT ); Thu, 2 Mar 2017 21:56:50 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:51939 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751518AbdCCC4q (ORCPT ); Thu, 2 Mar 2017 21:56:46 -0500 Subject: Re: Conversion of w83627ehf to hwmon_device_register_with_info ? To: =?UTF-8?Q?Peter_H=c3=bcwe?= , linux-hwmon@vger.kernel.org References: <201703030133.01363.PeterHuewe@gmx.de> Cc: Jean Delvare , linux-kernel@vger.kernel.org From: Guenter Roeck Message-ID: Date: Thu, 2 Mar 2017 18:56:01 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <201703030133.01363.PeterHuewe@gmx.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 830 Lines: 24 Hi Peter, On 03/02/2017 04:33 PM, Peter H?we wrote: > Hi, > > is anybody else working on the conversion of the w83627ehf to the new > hwmon_device_register_with_info interface? > I don't think so. > Otherwise I will probably update the driver to this interface within the next > days - but since it's a lot of work I wanted to check for duplication first. > Go ahead. I would suggest to drop nct6775/nct6776 support to simplify the code when you do that. Maybe as separate commit, though. > Do you think it makes sense to introduce a hwmon_sensor_types for "intrusion" > as well? - there are currently 8 drivers who offer that interface. > I don't really like the idea of introducing another type for just one attribute, but it might be the easiest and most consistent approach. Feel free to submit a patch to add it. Guenter